Skip to content

Build zstd with multithreading enabled #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2025
Merged

Build zstd with multithreading enabled #762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf0e8d1
Build zstd with multithreading enabled
zanieb Aug 16, 2025
8458f6b
Add test case
zanieb Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cpython-unix/build-zstd.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ index 5e6e8bc..6ca72a1 100644
EOF
fi

CFLAGS="${EXTRA_TARGET_CFLAGS} -fPIC" LDFLAGS="${EXTRA_TARGET_LDFLAGS}" make -j ${NUM_CPUS} libzstd.a
CFLAGS="${EXTRA_TARGET_CFLAGS} -DZSTD_MULTITHREAD -fPIC" LDFLAGS="${EXTRA_TARGET_LDFLAGS}" make -j ${NUM_CPUS} libzstd.a
make -j ${NUM_CPUS} install-static DESTDIR=${ROOT}/out
make -j ${NUM_CPUS} install-includes DESTDIR=${ROOT}/out
make -j ${NUM_CPUS} install-pc DESTDIR=${ROOT}/out
MT=1 make -j ${NUM_CPUS} install-pc DESTDIR=${ROOT}/out
9 changes: 9 additions & 0 deletions src/verify_distribution.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,15 @@ def test_gil_disabled(self):

self.assertEqual(sysconfig.get_config_var("Py_GIL_DISABLED"), wanted)

@unittest.skipIf(
sys.version_info[:2] < (3, 14),
"zstd is only available in 3.14+",
)
def test_zstd_multithreaded(self):
from compression import zstd

assert zstd.CompressionParameter.nb_workers.bounds() == (0, 256)

@unittest.skipIf("TCL_LIBRARY" not in os.environ, "TCL_LIBRARY not set")
@unittest.skipIf("DISPLAY" not in os.environ, "DISPLAY not set")
def test_tkinter(self):
Expand Down
Loading