Add support for Python 3.15 #819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I encountered a test failure during PGO, tracked in python/cpython#140125 — ignoring the test for now. |
zanieb
commented
Oct 14, 2025
Comment on lines
+400
to
+410
| if not python_source: | ||
| python_version = entry["version"] | ||
| archive = download_entry(entry_name, DOWNLOADS_PATH) | ||
| else: | ||
| python_version = os.environ["PYBUILD_PYTHON_VERSION"] | ||
| archive = DOWNLOADS_PATH / ("Python-%s.tar.xz" % python_version) | ||
| print("Compressing %s to %s" % (python_source, archive)) | ||
| with archive.open("wb") as fh: | ||
| create_tar_from_directory( | ||
| fh, python_source, path_prefix="Python-%s" % python_version | ||
| ) |
There was a problem hiding this comment.
There are some changes in here from my initial exploration of making 3.15 build from a source tree instead of a download entry. They're minor and fix bugs, so I think it's fine to leave them in.
zanieb
commented
Oct 14, 2025
geofft
approved these changes
Oct 14, 2025
| ) | ||
|
|
||
| elif action.startswith("cpython-") and action.endswith("-host"): | ||
| entry_name = action[:-5] |
There was a problem hiding this comment.
Suggested change
| entry_name = action[:-5] | |
| entry_name = action.removesuffix("-host") |
| def build_cpython_host( | ||
| client, | ||
| image, | ||
| entry, |
There was a problem hiding this comment.
Suggested change
| entry: dict, |
If we had a type hint here previously it would have been easier to see that it changed. :) Really we should throw a TypedDict at it.
Comment on lines
+396
to
+397
| python_source=None, | ||
| entry_name=None, |
There was a problem hiding this comment.
Small nit: at least one of these is required and in practice we seem to pass entry_name unconditionally. Can we do
Suggested change
| python_source=None, | |
| entry_name=None, | |
| entry_name: str, | |
| python_source: str | None = None, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.