Open
Conversation
WafflesVonMaple
approved these changes
Nov 11, 2025
Contributor
Greptile OverviewGreptile SummarySwitched from Celestia's broken
Issues Found:
Confidence Score: 4/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant Relayer as Sequencer Relayer
participant BlobTxClient as BlobTxClient<br/>(celestia.core.v1.tx)
participant CelestiaApp as Celestia App
Note over Relayer,CelestiaApp: Transaction Submission Flow
Relayer->>Relayer: try_prepare(blobs)
Relayer->>CelestiaApp: broadcast_tx(blob_tx)
CelestiaApp-->>Relayer: tx_hash
Note over Relayer,CelestiaApp: Transaction Confirmation Loop (NEW API)
loop Until transaction confirmed
Relayer->>BlobTxClient: tx_status(TxStatusRequest)
Note right of BlobTxClient: Uses celestia.core.v1.tx.Tx/TxStatus<br/>(replaces old GetTx API)
BlobTxClient->>CelestiaApp: gRPC: TxStatus
alt Transaction committed
CelestiaApp-->>BlobTxClient: TxStatusResponse<br/>(status="COMMITTED", height>0)
BlobTxClient-->>Relayer: Ok(Some(height))
else Transaction pending
CelestiaApp-->>BlobTxClient: Status: NotFound
BlobTxClient-->>Relayer: Ok(None)
Relayer->>Relayer: sleep and retry
else Transaction failed
CelestiaApp-->>BlobTxClient: TxStatusResponse<br/>(execution_code!=0)
BlobTxClient-->>Relayer: Err(GetTxResponseErrorCode)
end
end
Relayer->>Relayer: confirm_submission() returns height
|
Contributor
There was a problem hiding this comment.
Additional Comments (1)
-
crates/astria-sequencer-relayer/src/relayer/celestia_client/mod.rs, line 559-601 (link)style: Unused function -
block_height_from_response()is now dead code after switching fromGetTxtoTxStatusAPI. Consider removing it.
6 files reviewed, 1 comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brief summary of the changes made, ie "what?"
Background
Brief background on why these changes were made, ie "why?"
Changes
Testing
How are these changes tested?
Changelogs
Ensure all relevant changelog files are updated as necessary. See
keepachangelog for change
categories. Replace this text with e.g. "Changelogs updated." or "No updates
required." to acknowledge changelogs have been considered.
Metrics
Breaking Changelist
Related Issues
Link any issues that are related, prefer full GitHub links.
closes