-
Notifications
You must be signed in to change notification settings - Fork 97
chore: use the api celestia didn't break #2272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Greptile OverviewGreptile SummarySwitched from Celestia's broken
Issues Found:
Confidence Score: 4/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant Relayer as Sequencer Relayer
participant BlobTxClient as BlobTxClient<br/>(celestia.core.v1.tx)
participant CelestiaApp as Celestia App
Note over Relayer,CelestiaApp: Transaction Submission Flow
Relayer->>Relayer: try_prepare(blobs)
Relayer->>CelestiaApp: broadcast_tx(blob_tx)
CelestiaApp-->>Relayer: tx_hash
Note over Relayer,CelestiaApp: Transaction Confirmation Loop (NEW API)
loop Until transaction confirmed
Relayer->>BlobTxClient: tx_status(TxStatusRequest)
Note right of BlobTxClient: Uses celestia.core.v1.tx.Tx/TxStatus<br/>(replaces old GetTx API)
BlobTxClient->>CelestiaApp: gRPC: TxStatus
alt Transaction committed
CelestiaApp-->>BlobTxClient: TxStatusResponse<br/>(status="COMMITTED", height>0)
BlobTxClient-->>Relayer: Ok(Some(height))
else Transaction pending
CelestiaApp-->>BlobTxClient: Status: NotFound
BlobTxClient-->>Relayer: Ok(None)
Relayer->>Relayer: sleep and retry
else Transaction failed
CelestiaApp-->>BlobTxClient: TxStatusResponse<br/>(execution_code!=0)
BlobTxClient-->>Relayer: Err(GetTxResponseErrorCode)
end
end
Relayer->>Relayer: confirm_submission() returns height
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
crates/astria-sequencer-relayer/src/relayer/celestia_client/mod.rs, line 559-601 (link)style: Unused function -
block_height_from_response()is now dead code after switching fromGetTxtoTxStatusAPI. Consider removing it.
6 files reviewed, 1 comment
Summary
Brief summary of the changes made, ie "what?"
Background
Brief background on why these changes were made, ie "why?"
Changes
Testing
How are these changes tested?
Changelogs
Ensure all relevant changelog files are updated as necessary. See
keepachangelog for change
categories. Replace this text with e.g. "Changelogs updated." or "No updates
required." to acknowledge changelogs have been considered.
Metrics
Breaking Changelist
Related Issues
Link any issues that are related, prefer full GitHub links.
closes