RM Synthesis code that could be combined with imaging one day#262
Open
Luke-Pratley wants to merge 23 commits intoastro-informatics:developmentfrom
Open
RM Synthesis code that could be combined with imaging one day#262Luke-Pratley wants to merge 23 commits intoastro-informatics:developmentfrom
Luke-Pratley wants to merge 23 commits intoastro-informatics:developmentfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## development #262 +/- ##
===============================================
+ Coverage 86.46% 86.91% +0.44%
===============================================
Files 66 70 +4
Lines 6259 6602 +343
===============================================
+ Hits 5412 5738 +326
- Misses 847 864 +17
Continue to review full report at Codecov.
|
Collaborator
Author
|
This is ready to merge! |
Collaborator
|
hey @Luke-Pratley we're tidying up PR's for PURIFY, can you remember what the state of this PR is? It seems as though it's ready to go, provided a few conflicts? |
Collaborator
Author
|
@CosmoMatt I think it is fine for it to be merged tbh. It is adjacent to the interferometric imaging, so I am not surprised it is mostly ready to be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RM measurement operator + example of 1d reconstruction + tests