Merged
Conversation
tkoskela
approved these changes
Mar 6, 2025
Contributor
tkoskela
left a comment
tkoskela
left a comment
There was a problem hiding this comment.
This looks good as well, as long as the test pass
Comment on lines
-44
to
-47
| struct measurementOpInfo { | ||
| std::shared_ptr<sopt::LinearTransform<Vector<t_complex>>> measurement_transform; | ||
| t_real operator_norm; | ||
| }; |
Contributor
There was a problem hiding this comment.
I feel like the existence of this class was a good reason for this change :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires the corresponding SOPT pull request to go through; all references to the operator norm have been moved into the operator class. Tests involving the stochastic method now update the operator norm inside the lambda function so that it remains correct.