Skip to content

Conversation

@ElisR
Copy link
Contributor

@ElisR ElisR commented Sep 26, 2024

Temporary measure until #209 is fixed properly.

@ElisR
Copy link
Contributor Author

ElisR commented Sep 26, 2024

Feel free to change the wording, of course!

@codecov
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.10%. Comparing base (2c3d9e5) to head (0c5e664).
Report is 66 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #220   +/-   ##
=======================================
  Coverage   93.10%   93.10%           
=======================================
  Files          29       29           
  Lines        3146     3146           
=======================================
  Hits         2929     2929           
  Misses        217      217           
Flag Coverage Δ
93.10% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CosmoMatt
Copy link
Collaborator

Hi @ElisR thanks for adding this, I'll be getting onto #209 today.

@all-contributors please add @ElisR for bug, doc

@allcontributors
Copy link
Contributor

@CosmoMatt

I've put up a pull request to add @ElisR! 🎉

Copy link
Collaborator

@CosmoMatt CosmoMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @ElisR, definitely worth noting in the docstrings. If we weren't going to address this issue imminently I would perhaps suggest raising a more verbose warning in the code itself, but this should hopefully be redundant shortly!

@CosmoMatt CosmoMatt merged commit efeeada into astro-informatics:main Sep 27, 2024
@ElisR ElisR deleted the 209-document-low-precision branch September 30, 2024 06:57
@matt-graham matt-graham added the documentation Improvements or additions to documentation label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants