Skip to content

Conversation

@matt-graham
Copy link
Collaborator

Resolves #294

Factors out the torch autograd checks in precompute spherical and Wigner transform test modules in to separate tests, with some additional refactoring to reduce code duplication at the same time. These separate tests are also given a 'slow' mark and this used to skip these tests in GitHub Actions tests workflow when triggered by commits on a pull-request, while still running them for other triggers such as pushes to main and for scheduled tests. This should hopefully give us benefit of much quicker tests on PRs while still giving some visibility on whether these tests are passing regularly.

@codecov
Copy link

codecov bot commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.55%. Comparing base (922dae6) to head (a3f7cf5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #304      +/-   ##
==========================================
- Coverage   96.60%   96.55%   -0.06%     
==========================================
  Files          32       32              
  Lines        3450     3450              
==========================================
- Hits         3333     3331       -2     
- Misses        117      119       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@jasonmcewen jasonmcewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't reviewed super thoroughly but LGTM

@matt-graham matt-graham merged commit 0de6f11 into main May 26, 2025
14 checks passed
@matt-graham matt-graham deleted the mmg/mark-torch-grad-tests branch May 26, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PyTorch gradient tests are taking up a lot of test time

3 participants