Skip to content

Conversation

cramt
Copy link

@cramt cramt commented Feb 21, 2025

Some imagebuilders just dont have the variant in their name for.... reasons (example tplink-archer-c5-v2), took a while to debug but the fix is trivial to just add a baseFileName without the variant to the list of possible names

sorry about the formatting, ill use your formatting config if you want me to

Copy link

nix-ci-app bot commented Feb 21, 2025

NixCI is ready to run on this PR.
Maintainer: Comment nix-ci run to run now.

@astro
Copy link
Owner

astro commented Feb 22, 2025

Thank you!

The diff is hard to read, so I would love to have the reformatting in a separate commit, if you think the reformatting makes sense.

@astro
Copy link
Owner

astro commented Sep 9, 2025

Even a word-diff isn't helpful here. Did you reformat automatically? Which tool did you use? I could try redoing it myself in a separate commit.

@cramt
Copy link
Author

cramt commented Sep 10, 2025

oh sorry i completely forgot about this, the actual change is just this

        baseFileNames = [
          "${imageBuilderPrefix}${target}-${variant}.${uname.system}-${uname.processor}"
          "${imageBuilderPrefix}${target}.${uname.system}-${uname.processor}"
        ];
        possibleFileNames = lib.lists.flatten (builtins.map (extension: builtins.map (baseFileName: "${baseFileName}${extension}") baseFileNames) [".tar.zst" ".tar.xz"]);
        matches = builtins.filter (fileName: builtins.hasAttr fileName variantFiles) possibleFileNames;

@cramt
Copy link
Author

cramt commented Sep 10, 2025

yeah might be best to do in a seperate commit due to there also being merge conflicts with this pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants