Low state blazar#483
Merged
JulienPeloton merged 55 commits intoastrolabsoftware:blazar_reviewfrom Jan 15, 2025
Merged
Conversation
Creation of the low state detection module file
Computation from ZTF data release 22 Description: - 3FGL Name: Name of the source inthe 3FGL catalog - ZTF Name: ZTF tag associated beforehand - Array of Medians: Medians used to standardize the flux (np.nan if no median could be computed) - Computed Threshold: 10th percentile of the standardized flux from the data release - Observed Threshold: Measured flux during a previous redshift detrmination attempt - Redshift: Redshift found during the previous spectroscopic observation - Final Threshold: Minimum between the Computed Threshold and the Observed Threshold
Refont after utils.py creation
Edit documentation of low_state_
CTAO blazar comparison file (parquet) Computation from ZTF data release 22 Description: - 3FGL Name: Name of the source inthe 3FGL catalog - ZTF Name: ZTF tag associated beforehand - Array of Medians: Medians used to standardize the flux (np.nan if no median could be computed) - Computed Threshold: 10th percentile of the standardized flux from the data release - Observed Threshold: Measured flux during a previous redshift detrmination attempt - Redshift: Redshift found during the previous spectroscopic observation - Final Threshold: Minimum between the Computed Threshold and the Observed Threshold
Page setting
Update documentation
Fix name in standardized_flux_
Fix CTAO_PATH
Fix CTAO_PATH
JulianHamo
requested review from
JulienPeloton
and removed request for
JulienPeloton
JulienPeloton
approved these changes
Jan 10, 2025
Member
JulienPeloton
left a comment
JulienPeloton
left a comment
There was a problem hiding this comment.
Thanks @JulianHamo ! I left two minor comments :-)
.github/workflows/run_test.yml
Outdated
| rm -f /tmp/forest_*.onnx | ||
| ./run_tests.sh | ||
| ./run_tests.sh --single_module fink_science/standardized_flux/processor.py | ||
| ./run_tests.sh --single_module fink_science/blazar_low_state/processor.py |
Member
There was a problem hiding this comment.
Now you can remove this :-)
| Array of ratios for: | ||
| Mean over threshold of the last but one alert | ||
| Mean over threshold of the last alert | ||
| Measurement over threshold of the last alert |
Member
There was a problem hiding this comment.
You need to specify default values of -1 in case of problem.
JulienPeloton
approved these changes
Jan 15, 2025
Member
JulienPeloton
left a comment
JulienPeloton
left a comment
There was a problem hiding this comment.
Thanks @JulianHamo -- all good except the failure is due to the fact that the data file is not in the correct place. I'm merging and fixing the issue.
JulienPeloton
added a commit
that referenced
this pull request
Jan 15, 2025
* Low state blazar (#483) * Create processor.py Creation of the low state detection module file * CTAO blazar comparison file (parquet) Computation from ZTF data release 22 Description: - 3FGL Name: Name of the source inthe 3FGL catalog - ZTF Name: ZTF tag associated beforehand - Array of Medians: Medians used to standardize the flux (np.nan if no median could be computed) - Computed Threshold: 10th percentile of the standardized flux from the data release - Observed Threshold: Measured flux during a previous redshift detrmination attempt - Redshift: Redshift found during the previous spectroscopic observation - Final Threshold: Minimum between the Computed Threshold and the Observed Threshold * First writing draft of processor.py * Create utils.py * Update processor.py Refont after utils.py creation * Update utils.py Edit documentation of low_state_ * Create utils.py * Add files via upload CTAO blazar comparison file (parquet) Computation from ZTF data release 22 Description: - 3FGL Name: Name of the source inthe 3FGL catalog - ZTF Name: ZTF tag associated beforehand - Array of Medians: Medians used to standardize the flux (np.nan if no median could be computed) - Computed Threshold: 10th percentile of the standardized flux from the data release - Observed Threshold: Measured flux during a previous redshift detrmination attempt - Redshift: Redshift found during the previous spectroscopic observation - Final Threshold: Minimum between the Computed Threshold and the Observed Threshold * Create processor.py * Update utils.py * Create __init__.py * Create __init__.py * Create README.md * Update README.md Page setting * Create README.md * Update processor.py Update documentation * Update utils.py Fix name in standardized_flux_ * Update processor.py Fix CTAO_PATH * Update processor.py Fix CTAO_PATH * Update of CI script to run only on single modules * Update of CI script to run only on single modules * Update of CI script to run only on single modules * Update of standardized_flux/utils.py * Change from 'low' to 'quiescent' * Documentation update * PEP8 check test * PEP8 fix * __init__.py fix * PEP8 fix test * PEP8 fix test * PEP8 fix test * PEP8 fix test * PEP8 fix test * Datatest creation * Shrinking of datatest size * PEP8 fix * Datatest path change * Example fix * Example fix * Example fix * Modification of tester.py * Modification of CTAO_blazars path * Modification of CTAO_blazars path * Modification of CTAO_blazars path * Modification of CTAO_blazars path * Modification of CTAO_blazars path * Example fix attempt * Example fix attempt * Example fix attempt * PATH change * Test addition * Test addition * Test addition * Test addition * Minor corrections --------- Co-authored-by: Julian <julian@> * Move Blazar file * Fix Illegal Parquet type: INT64 (TIMESTAMP_MICROS) error by recreating the file --------- Co-authored-by: JulianHamo <hamo@ijclab.in2p3.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please create an issue first before opening a Pull Request.
Linked to issue(s): Closes put link
If this is a new release, did you issue the corresponding schema in fink-client?
otherwise you'll break the livestream service!
What changes were proposed in this pull request?
How is the issue this PR is referenced against solved with this PR?
How was this patch tested?