-
Notifications
You must be signed in to change notification settings - Fork 10
PINF-41 - Add pgbouncer exporter service with chainguard base image #1134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
||
| # https://hub.docker.com/r/jbub/pgbouncer_exporter | ||
| FROM jbub/pgbouncer_exporter:v0.20.0 AS upstream | ||
| FROM cgr.dev/astronomer.io/prometheus-pgbouncer-exporter:v0.11.0 AS upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| FROM cgr.dev/astronomer.io/prometheus-pgbouncer-exporter:v0.11.0 AS upstream | |
| FROM cgr.dev/astronomer.io/prometheus-pgbouncer-exporter:v0.20.0 AS upstream |
Co-authored-by: pgvishnuram <81585115+pgvishnuram@users.noreply.github.com>
|
|
||
| # https://hub.docker.com/r/jbub/pgbouncer_exporter | ||
| FROM jbub/pgbouncer_exporter:v0.20.0 AS upstream | ||
| FROM cgr.dev/astronomer.io/prometheus-pgbouncer-exporter:v0.11.0 AS upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yikes, are we reverting from 0.20.0 to 0.11.0 ? Does chainguard not have a newer one? 0.11.0 is from 2021 https://github.com/jbub/pgbouncer_exporter/releases/tag/v0.11.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danielhoherd looks like Chainguard is not matching its versioning with OSS upstream image versions?
In this case, should we just adopt Chainguard's version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot use pgbouncer-exporter 0.11.0. it is incompatible with our version of pgbouncer 1.24 https://github.com/jbub/pgbouncer_exporter/releases/tag/v0.19.0
Slack thread: https://astronomer.slack.com/archives/C08CL6S53J6/p1769709287900579
Details
This PR migrates upstream pgbouncer exporter image to chainguard image. This PR sets explicit
ENTRYPOINTandCMDto support dynamic credential injection via environment variables.Related Issues
https://github.com/astronomer/issues/issues/8240
Testing
Checklist