Skip to content

Conversation

@hombit
Copy link
Contributor

@hombit hombit commented Dec 23, 2025

It has much nicer diff message when things fail

Previously:

  Full diff:
    catalog_name      small_sky_from_dataframe
    catalog_type      object
    total_rows        111
    ra_column         ra
    dec_column        dec
    healpix_column    _healpix_29
    healpix_order     29
    npix_suffix       .parquet
    skymap_order      8
    skymap_alt_orders 1 2
    hats_max_rows     111
    hats_max_bytes    1073741824

After:

Full diff:
    {
        'assn_max_separation': None,
        'catalog_name': 'small_sky_from_dataframe',
        'catalog_type': 'object',
        'contains_leaf_files': None,
        'dec_column': 'dec',
        'default_columns': None,
        'extra_columns': None,
        'hats_builder': 'lsdb v0.7.4.dev25+g3714254d2, hats v0.7.4.dev8+g369ce88f8',
        'hats_creation_date': None,
        'hats_estsize': None,
        'hats_max_bytes': 1073741824,
  -     'hats_max_rows': '111',
  ?                      -   -
  +     'hats_max_rows': 111,
        'hats_release_date': '2025-08-22',
        'hats_version': 'v1.0',
        'healpix_column': '_healpix_29',
        'healpix_order': 29,
        'indexing_column': None,
        'join_catalog': None,
        'join_column': None,
        'join_column_association': None,
        'margin_threshold': None,
        'npix_suffix': '.parquet',
        'obs_regime': 'Optical',
        'primary_catalog': None,
        'primary_column': None,
        'primary_column_association': None,
        'ra_column': 'ra',
        'skymap_alt_orders': '1 2',
        'skymap_order': 8,
        'total_rows': 111,
    }

It has much nicer diff message when things fail
@hombit hombit requested a review from delucchi-cmu December 23, 2025 17:46
@github-actions
Copy link

Before [7f03c42] After [b3651b5] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.BenchmarksCDSHTTP.time_gaia
851±40ms failed n/a benchmarks.BenchmarksHTTP.time_gaia
360M 365M 1.01 benchmarks.BenchmarksHTTP.peakmem_gaia
419M 418M 1.00 benchmarks.BenchmarksS3.peakmem_euclid
814±0.6ms 787±5ms 0.97 benchmarks.BenchmarksS3.time_euclid

Click here to view all benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants