Skip to content

Loading a catalog with the same label replaces old data. #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2025
Merged

Loading a catalog with the same label replaces old data. #78

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de8d180
Refactor initialization to make subclassing easier
mwcraig Jul 7, 2025
3d805b5
Remove unused attributes in sample viewer
mwcraig Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions src/astro_image_display_api/image_viewer_logic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,16 +74,14 @@ class ImageViewerLogic:
state to simulate the behavior of a real viewer.
"""

_cuts: BaseInterval | tuple[float, float] = AsymmetricPercentileInterval(
upper_percentile=95
)
_stretch: BaseStretch = LinearStretch

# some internal variable for keeping track of viewer state
_wcs: WCS | None = None
_center: tuple[numbers.Real, numbers.Real] = (0.0, 0.0)

def __post_init__(self):
self._set_up_catalog_image_dicts()

def _set_up_catalog_image_dicts(self):
# This is a dictionary of marker sets. The keys are the names of the
# marker sets, and the values are the tables containing the markers.
self._catalogs = defaultdict(CatalogInfo)
Expand Down Expand Up @@ -186,9 +184,9 @@ def set_cuts(
**kwargs, # noqa: ARG002
) -> None:
if isinstance(value, tuple) and len(value) == 2:
self._cuts = ManualInterval(value[0], value[1])
cuts = ManualInterval(value[0], value[1])
elif isinstance(value, BaseInterval):
self._cuts = value
cuts = value
else:
raise TypeError(
"Cuts must be an Astropy.visualization Interval object or a tuple "
Expand All @@ -199,7 +197,7 @@ def set_cuts(
raise ValueError(
f"Image label '{image_label}' not found. Please load an image first."
)
self._images[image_label].cuts = self._cuts
self._images[image_label].cuts = cuts

def set_colormap(
self,
Expand Down