Simplify pytest remote data mock setup#103
Conversation
a0c5974 to
dfb6fad
Compare
|
@eteq Can you please review this? |
|
@cdeil - I'm not sure this actually solves the problem #98 was initially meant to fix. With this version, you always turn on mocking of My thinking is that that's a feature, not a bug. That is, it's better to write To be more concrete, here we should have tests that actually test if The rest of it are good changes, though. |
|
After a lengthy discussion on slack, @bmorris3 broke the tie and said we should switch to this behavior. So I'll merge this PR, and after this, |
Simplify pytest remote data mock setup and change behavior to make --remote-data mean don't use mock anywhere
This is an attempt to simplify the pytest remote data mock setup that was introduced in #98.
Please see #98 (comment) and #98 (comment) as well as the
docstring of
_mock_remote_datain this PR where I try to explain how it works and why it's an improvement.