Skip to content

Fix TimeDeltaMissingUnitWarning in plot_airmass#611

Open
H-xie wants to merge 1 commit intoastropy:mainfrom
H-xie:patch-1
Open

Fix TimeDeltaMissingUnitWarning in plot_airmass#611
H-xie wants to merge 1 commit intoastropy:mainfrom
H-xie:patch-1

Conversation

@H-xie
Copy link

@H-xie H-xie commented Jan 6, 2025

The function plot_airmass triggers the warning TimeDeltaMissingUnitWarning. This issue arises from unit checks implemented in newer versions of Astropy (refer to commit d8968b29a209fdaebd0f48ff30863718bca9db78).

The warning is generated because a time value without a unit is being added to an Astropy Time object. To resolve this warning, it is recommended to add the unit u.hour to the time value.

The function `plot_airmass` triggers the warning `TimeDeltaMissingUnitWarning`. This issue arises from unit checks implemented in newer versions of Astropy (refer to commit d8968b29a209fdaebd0f48ff30863718bca9db78).

The warning is generated because a time value without a unit is being added to an Astropy Time object. To resolve this warning, it is recommended to add the unit `u.hour` to the time value.
Copy link

@m4cd4r4 m4cd4r4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean fix for the TimeDeltaMissingUnitWarning. One thing worth checking:

In the datetime branch above this line, tzoffset is set to a bare float (from time.utcoffset().total_seconds() / 3600). If that value is later added to an astropy Time object, the same warning would appear for timezone-aware datetime inputs.

Worth adding * u.hour to the datetime branch too:

tzoffset = time.utcoffset().total_seconds() / 3600 * u.hour

Otherwise this is a straightforward one-liner that fixes a real warning. Looks like it needs a rebase to trigger CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants