Conversation
e298042 to
89bcf77
Compare
d6e14f5 to
72ed121
Compare
| ] | ||
| ], | ||
| ["Documentation", | ||
| [ |
There was a problem hiding this comment.
At the moment I have just linked the coordinated packages here. We need to decide if we want to list all affiliated packages or not.
As you can see on https://sunpy.org it's possible to have collapsible sections here, so we could choose to put all the affiliated packages under a click to reveal list.
There was a problem hiding this comment.
It should also be noted that by default if we list all the affiliated packages here they will also be included in the unified search results (as long as they are hosted on RTD).
| ["Team", "team.html", 2], | ||
| ] | ||
| rtd_extra_search_projects = [["astropy-org-test", "https://astropy-org-test.readthedocs.io"]] | ||
| footer_links = [["Code of Conduct", "code_of_conduct.html", 2]] No newline at end of file |
There was a problem hiding this comment.
At the moment I have only put the CoC in the footer.
The footer on astropy.org is quite different before this theme so we might want to customize the footer further.
85a6026 to
60c11e5
Compare
|
I didn't realise you could do that unless the base branch was on the upstream repo. I'll have a look! |
Ah, maybe you are right and we could only do that as I cannot convince my team to use fork-based development 🙄 |
This brings it closer to astropy#48 as well
4a43cd6 to
e35f7e4
Compare
| ["specreduce", "https://specreduce.readthedocs.io", 3], | ||
| ["specutils", "https://specutils.readthedocs.io", 3], | ||
| ] | ||
| ], |
There was a problem hiding this comment.
docs.astropy.org has a learn link in the header, would we like to add one here?
e35f7e4 to
e71c421
Compare
|
(The CI is failing because of GitHub flakiness) |
| dependencies = ["sphinx>6"] | ||
| dependencies = [ | ||
| "sphinx>6", | ||
| "sunpy-sphinx-theme@git+https://github.com/sunpy/sunpy-sphinx-theme", |
There was a problem hiding this comment.
So just to check, what is required here? Are there some unreleased changes in the sunpy sphinx theme?
There was a problem hiding this comment.
yes, I keep finding bugs or things to tweak while doing this so I'm stalling on releasing the sunpy theme till I've found them all more of them.
There was a problem hiding this comment.
"found them all"
Wow, that level of optimism 🤣 (I see the correction, yet :) )
There was a problem hiding this comment.
Did sunpy-sphinx-theme get new release yet? I don't think we can merge until the theme is out.
There was a problem hiding this comment.
I don't think we are close to merging this 😜
|
Also it's way too much orange even though Erik T would probably like it given astropy/astropy#15111 |
|
Just a quick note that I find the new theme quite pleasant -- but then, I've grown up in NL so like the colour orange ... |
I don't think there's an easy way to fix this problem and it doesn't seem to me that it's going to be a big problem? |
Maybe I am outlier but I work with astropy almost exclusively in the dev version, and I confused myself in the first few mins navigating that menu. |
|
That's really interesting to me, I'd never use that menu to get back to the documentation homepage, but now you've said it I can see people doing it. For what it's worth nobody has ever complained about doing this with the sunpy docs 🤷 I've opened this: sunpy/sunpy-sphinx-theme#308 I hope you don't consider this a blocking issue 🙈 |
In that there's too many occurrences of the colour orange or that the orange is too orange? Also light theme or dark? I haven't put a lot of effort into the colouring yet, so I'm happy to tweak things some. However, I also don't have a load of time to prod around with CSS if I want to get this rolled out to all the packages within budget. |
|
Thanks! I don't think it is blocking.
Also non-blocking. Just an observation. Marten seems happy with it. |
|
this looks great. I love the improved discoverability ! |

This PR adds the new theme.
You can see built documentation with this theme in the following places: