maint: add deprecation warning on find_datasets that can be replaced by query_region

Author: ManonMarchand

astroquery/mocserver/core.py

@@ -10,6 +10,7 @@
 
 from astropy import units as u
 from astropy.table import Table
+from astropy.utils import deprecated
 
 try:
     from mocpy import MOC, TimeMOC, STMOC
@@ -222,6 +223,8 @@ def query_hips(
             cache=cache,
         )
 
+    @deprecated(since="v0.4.9",
+                alternative="query_region")
     def find_datasets(
         self, meta_data,
         *,

astroquery/mocserver/tests/test_mocserver.py

@@ -7,6 +7,7 @@
 from astropy import coordinates
 from astropy.io.votable import parse_single_table
 from astropy.table import Table
+from astropy.utils.exceptions import AstropyDeprecationWarning
 
 try:
     from mocpy import MOC, STMOC, TimeMOC, FrequencyMOC
@@ -270,5 +271,6 @@ def test_cast_to_float():
 
 def test_find_datasets():
     # find datasets is useless as it does the same than query region
-    old = MOCServer.find_datasets(meta_data="ID=*Euclid*", get_query_payload=True)
+    with pytest.warns(AstropyDeprecationWarning, match="The find_datasets function *"):
+        old = MOCServer.find_datasets(meta_data="ID=*Euclid*", get_query_payload=True)
     assert old == MOCServer.query_region(meta_data="ID=*Euclid*", get_query_payload=True)