MAINT: addressing minor review comments

Author: bsipocz

astroquery/besancon/tests/test_besancon.py

@@ -68,8 +68,7 @@ def get_readable_fileobj_mockreturn(filename, **kwargs):
                 with open(data_path('1376235131.430670.resu'), "r" + ('b' if is_binary else '')) as file_obj:
                     yield file_obj
         else:
-            file_obj = filename
-            yield file_obj
+            yield filename
 
     mp = request.getfixturevalue("monkeypatch")
 

astroquery/cadc/tests/test_cadctap_remote.py

@@ -300,13 +300,13 @@ def test_uploads(self, tmp_path):
         # save a few observations on a local file
         output_file = Path(tmp_path, 'my_observations.xml')
         cadc.exec_sync("SELECT TOP 3 observationID FROM caom2.Observation",
-                       output_file=output_file)#'my_observations.xml')
-#        assert output_file.exists()
+                       output_file=output_file)
+        assert output_file.exists()
 
         # now use them to join with the remote table
         results = cadc.exec_sync(
             "SELECT o.observationID, intent FROM caom2.Observation o JOIN "
             "tap_upload.test_upload tu ON o.observationID=tu.observationID",
-            uploads={'test_upload': output_file})#'my_observations.xml'})
+            uploads={'test_upload': output_file})
 
         assert len(results) == 3

astroquery/sdss/core.py

@@ -944,7 +944,7 @@ def _parse_result(self, response, verbose=False):
                 warnings.filterwarnings("ignore", category=AstropyWarning,
                                         message=r'OverflowError converting to IntType in column.*')
             arr = Table.read(response.text, format='ascii.csv', comment="#")
-            for id_column in ['objid', 'specobjid']:
+            for id_column in ('objid', 'specobjid'):
                 if id_column in arr.columns:
                     arr[id_column] = arr[id_column].astype(np.int64)