ENH: querying tool for the Planetary Ring Node#2358

Merged

bsipocz merged 25 commits intoastropy:mainfrom

emolter:ringnode

Jan 5, 2023

Commits on Jan 5, 2023

started building infrastructure for solarsystem.pds.RingNode

Edward Molter
authored and
bsipocz
committed
minimum working example. parses basic query for all six targets

Edward Molter
authored and
bsipocz
committed
allowed option to pass observatory coordinates

Edward Molter
authored and
bsipocz
committed
added some tests

Edward Molter
authored and
bsipocz
committed
attempted to fix all pep8 problems

Edward Molter
authored and
bsipocz
committed
added units, some fixes suggested by mkelley

emolter
authored and
bsipocz
committed
added offline test

emolter
authored and
bsipocz
committed
small fixes to tests, improved documentation

emolter
authored and
bsipocz
committed
added test for Pluto, wrote an rst file

emolter
authored and
bsipocz
committed
small fixes as suggested by mkelley, and trying to fix docs

emolter
authored and
bsipocz
committed
tests for Saturn, Neptune special cases

emolter
authored and
bsipocz
committed
made (hopefully) all changes from code review

emolter
authored and
bsipocz
committed
made all changes suggested by @eerovaher

emolter
authored and
bsipocz
committed
attempted fix to AttributeError: 'RingNodeClass' object has no attribute '_last_query'

emolter
authored and
bsipocz
committed
complying with template in pull request #2341

emolter
authored and
bsipocz
committed
fixes suggested by @eerovaher

emolter
authored and
bsipocz
committed
changes suggested by @bsipocz

emolter
authored and
bsipocz
committed
made adding units with QTable back-compatible with 3.7

emolter
authored and
bsipocz
committed
fixing oldest dependencies table read duplicate column error

Edward Molter
authored and
bsipocz
committed
added support for jwst

Edward Molter
authored and
bsipocz
committed
forgot to test before push :facepalm:

Edward Molter
authored and
bsipocz
committed
changes suggested by @bsipocz, most importantly adding platform-independent newline handling

Edward Molter
authored and
bsipocz
committed
changelog entry

Edward Molter
authored and
bsipocz
committed
Addressing final review items
bsipocz
committed
Fix windows parsing
bsipocz
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

ENH: querying tool for the Planetary Ring Node#2358

ENH: querying tool for the Planetary Ring Node#2358
bsipocz merged 25 commits intoastropy:mainfrom
emolter:ringnode

Commits on Jan 5, 2023

started building infrastructure for solarsystem.pds.RingNode

minimum working example. parses basic query for all six targets

allowed option to pass observatory coordinates

added some tests

attempted to fix all pep8 problems

added units, some fixes suggested by mkelley

added offline test

small fixes to tests, improved documentation

added test for Pluto, wrote an rst file

small fixes as suggested by mkelley, and trying to fix docs

tests for Saturn, Neptune special cases

made (hopefully) all changes from code review

made all changes suggested by @eerovaher

attempted fix to AttributeError: 'RingNodeClass' object has no attribute '_last_query'

complying with template in pull request #2341

fixes suggested by @eerovaher

changes suggested by @bsipocz

made adding units with QTable back-compatible with 3.7

fixing oldest dependencies table read duplicate column error

added support for jwst

forgot to test before push :facepalm:

changes suggested by @bsipocz, most importantly adding platform-independent newline handling

changelog entry

Addressing final review items

Fix windows parsing

Uh oh!

ENH: querying tool for the Planetary Ring Node#2358bsipocz merged 25 commits intoastropy:mainastropy/astroquery:mainfrom emolter:ringnodeCopy head branch name to clipboard

Commits

Commits on Jan 5, 2023

ENH: querying tool for the Planetary Ring Node#2358
bsipocz merged 25 commits intoastropy:mainfrom
emolter:ringnode