-
-
Notifications
You must be signed in to change notification settings - Fork 424
Implement batching in Observations.get_product_list and add batch_size parameter
#3454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3454 +/- ##
==========================================
+ Coverage 70.72% 70.73% +0.01%
==========================================
Files 232 232
Lines 20041 20040 -1
==========================================
+ Hits 14174 14176 +2
+ Misses 5867 5864 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
|
Please don't prompt copilot to add noise here. |
|
Oops, sorry! |
Add
batch_sizeparameter toMastMissions.get_product_list,Observations.get_product_list, andutils.resolve_objectto allow controlling the number of items sent in each batch request to the server. This can help avoid timeouts or connection errors for large requests.I also did some refactoring in the
MastMissionsmodule to make it more consistent withObservationsas far as what is returned byget_product_list_async.