Skip to content

Conversation

@snbianco
Copy link
Contributor

@snbianco snbianco commented Nov 6, 2025

Add batch_size parameter to MastMissions.get_product_list, Observations.get_product_list, and utils.resolve_object to allow controlling the number of items sent in each batch request to the server. This can help avoid timeouts or connection errors for large requests.

I also did some refactoring in the MastMissions module to make it more consistent with Observations as far as what is returned by get_product_list_async.

@snbianco snbianco added the mast label Nov 6, 2025
@snbianco snbianco requested a review from Copilot November 6, 2025 15:51
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 70.73%. Comparing base (91fad25) to head (27967f7).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
astroquery/mast/missions.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3454      +/-   ##
==========================================
+ Coverage   70.72%   70.73%   +0.01%     
==========================================
  Files         232      232              
  Lines       20041    20040       -1     
==========================================
+ Hits        14174    14176       +2     
+ Misses       5867     5864       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@bsipocz
Copy link
Member

bsipocz commented Nov 6, 2025

Please don't prompt copilot to add noise here.

@snbianco
Copy link
Contributor Author

snbianco commented Nov 6, 2025

Oops, sorry!

@snbianco snbianco marked this pull request as ready for review November 6, 2025 16:18
@snbianco snbianco requested a review from bsipocz November 6, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants