-
-
Notifications
You must be signed in to change notification settings - Fork 424
Move JPLSpec to linelists/ #3455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
keflavich
wants to merge
2
commits into
astropy:main
Choose a base branch
from
keflavich:move_jplspec
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,33 @@ | ||
| # Licensed under a 3-clause BSD style license - see LICENSE.rst | ||
| """ | ||
| JPL Spectral Catalog | ||
| -------------------- | ||
| JPL Spectral Catalog (Deprecated Location) | ||
| ------------------------------------------- | ||
| .. deprecated:: 0.4.8 | ||
| The `astroquery.jplspec` module has been moved to `astroquery.linelists.jplspec`. | ||
| Please update your imports to use `from astroquery.linelists.jplspec import JPLSpec` instead. | ||
| This backward compatibility layer will be removed in a future version. | ||
| :author: Giannina Guzman ([email protected]) | ||
| :author: Miguel de Val-Borro ([email protected]) | ||
| """ | ||
| from astropy import config as _config | ||
| This module provides backward compatibility for the old import location. | ||
| The JPLSpec module has been reorganized under the linelists subpackage. | ||
| For new code, please use:: | ||
| class Conf(_config.ConfigNamespace): | ||
| """ | ||
| Configuration parameters for `astroquery.jplspec`. | ||
| """ | ||
| server = _config.ConfigItem( | ||
| 'https://spec.jpl.nasa.gov/cgi-bin/catform', | ||
| 'JPL Spectral Catalog URL.') | ||
|
|
||
| timeout = _config.ConfigItem( | ||
| 60, | ||
| 'Time limit for connecting to JPL server.') | ||
| from astroquery.linelists.jplspec import JPLSpec | ||
| """ | ||
| import warnings | ||
|
|
||
| conf = Conf() | ||
| # Issue deprecation warning | ||
| warnings.warn( | ||
| "Importing from 'astroquery.jplspec' is deprecated. " | ||
| "Please use 'from astroquery.linelists.jplspec import JPLSpec' instead. " | ||
| "The old import path will be removed in a future version.", | ||
| DeprecationWarning, | ||
| stacklevel=2 | ||
| ) | ||
|
|
||
| from .core import JPLSpec, JPLSpecClass | ||
| # Import from the new location | ||
| from ..linelists.jplspec import JPLSpec, JPLSpecClass, Conf, conf | ||
|
|
||
| __all__ = ['JPLSpec', 'JPLSpecClass', | ||
| 'Conf', 'conf', | ||
| ] | ||
| __all__ = ['JPLSpec', 'JPLSpecClass', 'Conf', 'conf'] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| # Licensed under a 3-clause BSD style license - see LICENSE.rst | ||
| """ | ||
| JPL Spectral Catalog | ||
| -------------------- | ||
| :author: Giannina Guzman ([email protected]) | ||
| :author: Miguel de Val-Borro ([email protected]) | ||
| """ | ||
| from astropy import config as _config | ||
|
|
||
|
|
||
| class Conf(_config.ConfigNamespace): | ||
| """ | ||
| Configuration parameters for `astroquery.linelists.jplspec`. | ||
| """ | ||
| server = _config.ConfigItem( | ||
| 'https://spec.jpl.nasa.gov/cgi-bin/catform', | ||
| 'JPL Spectral Catalog URL.') | ||
|
|
||
| timeout = _config.ConfigItem( | ||
| 60, | ||
| 'Time limit for connecting to JPL server.') | ||
|
|
||
|
|
||
| conf = Conf() | ||
|
|
||
| from .core import JPLSpec, JPLSpecClass | ||
|
|
||
| __all__ = ['JPLSpec', 'JPLSpecClass', | ||
| 'Conf', 'conf', | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes
File renamed without changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if this is necessary or right. I have no experience playing with stacklevels yet.