Skip to content

Initial draft of interface definition #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 50 commits into
base: main
Choose a base branch
from
Draft

Initial draft of interface definition #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
4b18213
Initial draft on interface definition
mwcraig Jul 2, 2021
9ee09df
Minimal change implementation of concrete ginga viewer
mwcraig Jul 12, 2021
fead302
Partial implementation of bqplot astro widget
mwcraig Jul 16, 2021
ccd5c39
Update astrowidgets/bqplot.py
mwcraig Jul 26, 2021
f9649c0
Set default cuts and auto-scale image
mwcraig Jul 28, 2021
6e73ade
Add basic cursor display
mwcraig Jul 28, 2021
9ba1839
Do not reset view when cuts change
mwcraig Jul 28, 2021
9e6e037
Make pixel index correspond to center of pixel in viewer
mwcraig Jul 28, 2021
0fbb617
PL ginga changes
mwcraig Aug 27, 2021
16d348e
Move ginga implementations back to ginga class
mwcraig Aug 27, 2021
a616101
Factor ginga-specific code out of base test class
mwcraig Aug 27, 2021
aab7edd
Add ginga viewer test
mwcraig Aug 27, 2021
518c908
Add bqplot viewer test
mwcraig Aug 27, 2021
7cc8a0c
Remove ginga-specific test code
mwcraig Aug 27, 2021
c2fc5b7
Make warning message checks more flexible
mwcraig Aug 27, 2021
88a2666
Bring bqplot closer to passing API tests
mwcraig Aug 27, 2021
9d08403
New offset_by with new API.
pllim Jul 1, 2021
819c115
Remove incorrect creation of WCS
mwcraig Aug 30, 2021
9ebc27f
Ensure save only overwrites if user wants that
mwcraig Aug 30, 2021
a57ed37
Change assertion to ValueError to match API
mwcraig Aug 30, 2021
14662e8
Do not alert user that scroll_pan actually doesn't work
mwcraig Aug 30, 2021
feda94b
Handle several marker-related settings
mwcraig Aug 30, 2021
efdf200
Add a few more API attributes
mwcraig Aug 30, 2021
4b206c1
Fix bug in error messages
mwcraig Aug 30, 2021
657f294
Add several methods for implementing markers
mwcraig Aug 30, 2021
4bdd27d
Implement offset_by
mwcraig Aug 30, 2021
e228174
Rewrite test classes to use fixtures instead of setup_class
mwcraig Aug 30, 2021
1e9962e
DOC: Update user-facing doc.
pllim Feb 19, 2021
33799e3
DOC: Fix inheritance diagram for Ginga API.
pllim Feb 22, 2021
bedd9f6
Allow the image widget to detect GUI zoom changes
mwcraig Sep 12, 2021
c8cd3cf
Add click_center functionality
mwcraig Sep 17, 2021
da5ac8e
Respond to changes in cursor value
mwcraig Sep 17, 2021
5c47658
Fix bug in setting up stretch
mwcraig Sep 17, 2021
0c5048a
Fix errors in marking setup
mwcraig Sep 17, 2021
a7e9384
Handle case when user does not specify marker name in add_markers
mwcraig Sep 17, 2021
584ebf5
Add click-to-mark functionality
mwcraig Sep 22, 2021
3de921a
WIP bqplot widget notebook
mwcraig Oct 27, 2021
838d027
Propogate marker API changes
mwcraig May 4, 2023
da4fd3f
Use proper numpy type names
mwcraig May 4, 2023
a196d29
Finish most of API implementation
mwcraig May 4, 2023
bf3f0bb
Clean up tests
mwcraig May 4, 2023
5fd58a3
Remove cell outputs in sample notebook
mwcraig May 4, 2023
9b747ff
Add traitlet/widget related warnings to ignore list
mwcraig May 4, 2023
10abb5e
Restore a couple of constants that got los in the refactor
mwcraig May 4, 2023
92c2eb5
Remove base class tests
mwcraig May 4, 2023
2f3bd38
Remove pixel offset from ginga widget
mwcraig May 5, 2023
cccd747
Update marker method names in test
mwcraig May 5, 2023
8bc7c3d
Replace cut test with something sensible
mwcraig May 5, 2023
5be93fb
Update more marker tests
mwcraig May 5, 2023
82a7844
Add widget arguments to ginga
mwcraig May 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/ci_workflows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ jobs:
flake8 astrowidgets --count

tests:
name: ${{ matrix.name }}
runs-on: ${{ matrix.os }}
strategy:
fail-fast: true
Expand All @@ -48,8 +49,6 @@ jobs:
- name: Run tests
run: tox -e py39-test

devtests:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v3
Expand Down
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ MANIFEST
example_notebooks/test.png
*/version.py
pip-wheel-metadata/
example_notebooks/ginga/test.png

# Sphinx
docs/api
Expand Down
2 changes: 1 addition & 1 deletion astrowidgets/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@
from ._astropy_init import * # noqa
# ----------------------------------------------------------------------------

from .core import * # noqa
# from .core import * # noqa
Loading