Conversation
…nltk or fortex.nltk to prevent version conflicts initally and use all-in-one approach to make sure the test code will be run the same way with 0.2.0 and new version > 0.3.0.
… neck related to nested generator/sortedlist area in DataPack.
…ne) : please provide conll data directory to the commented out "input_dir" parameter in code.
…ovide output local dir name in serialization test case.
Codecov Report
@@ Coverage Diff @@
## master #905 +/- ##
==========================================
- Coverage 81.05% 80.99% -0.07%
==========================================
Files 256 257 +1
Lines 19851 19999 +148
==========================================
+ Hits 16091 16198 +107
- Misses 3760 3801 +41
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
hunterhector
left a comment
hunterhector
left a comment
There was a problem hiding this comment.
- Maybe we also want to produce some numbers for the test?
- How to run this test on actual data (like ontonotes), we shoud provide instructions.
- The first line "PR fixes" message is not correctly formatted. Github won't associate the PR to the issue like this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes [https://github.com//issues/805].
Description of changes
According to discussion and requirements in the ticket and , a new test NLP pipeline using Forte is created in a new test class "NLP_Pipeline_Performance_Test" to cover typical scenarios relating to entry/token, such as serialization, POS tagging and NER as mentioned in the ticket. Also to make sure 0.2.0 and current code base are run in exactly some way/code, some code in copied from some referenced (but changed over the version) packages, to make sure we perform an apple to apple test
Possible influences of this PR.
This can be used in several iterations of profiling-improvement efforts, that adding profiling coverage on key/typical scenarios.
Test Conducted
Profiling test on serialization, POS tagging and NER as requested in [https://github.com/J007X/forte/tree/implementation_805].