Conversation
Codecov Report
@@ Coverage Diff @@
## master #299 +/- ##
==========================================
+ Coverage 82.63% 82.93% +0.29%
==========================================
Files 207 215 +8
Lines 16006 17271 +1265
==========================================
+ Hits 13226 14323 +1097
- Misses 2780 2948 +168
Continue to review full report at Codecov.
|
|
I agree that their implementations are a bit different and it's more reliable to use their code as is, but I don't think I would approve of merging into master at this point. True, if I were to choose between installing Speaking of too much code, although not related to this PR, I think it's better to move the |
Add texar-styled ELMo encoder adapted from allennlp. The corresponding tokenizer will be in another PR.
Resolve some comments in #298
I checked the implementation of
ELMoinallennlp, It seems that they used customized LSTM such that we cannot use ourLSTMmodule to implement it directly. And theHighwaymodule they used is different from ourHighwayWrapper. I feel that it is better to directly use their implementations, and the correctness of the implementation is guaranteed by their unit tests. Please let me know your thought @huzecong