Skip to content

Fix the handling of required fields populated from headers #1489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix the handling of required fields populated from headers #1489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 13 additions & 16 deletions src/CodeGenerator/src/Generator/CodeGenerator/PopulatorGenerator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,39 +190,36 @@ private function generatePopulator(Operation $operation, StructureShape $shape,
$memberShape = $member->getShape();
switch ($memberShape->getType()) {
case 'timestamp':
$body .= strtr('$this->PROPERTY_NAME = isset($headers["LOCATION_NAME"][0]) ? new \DateTimeImmutable($headers["LOCATION_NAME"][0]) : null;' . "\n", [
'PROPERTY_NAME' => $propertyName,
'LOCATION_NAME' => $locationName,
]);
$input = 'new \DateTimeImmutable($headers["LOCATION_NAME"][0])';

break;
case 'integer':
case 'long':
$body .= strtr('$this->PROPERTY_NAME = isset($headers["LOCATION_NAME"][0]) ? (int) $headers["LOCATION_NAME"][0] : null;' . "\n", [
'PROPERTY_NAME' => $propertyName,
'LOCATION_NAME' => $locationName,
]);
$input = '(int) $headers["LOCATION_NAME"][0]';

break;
case 'boolean':
$this->requirementsRegistry->addRequirement('ext-filter');

$body .= strtr('$this->PROPERTY_NAME = isset($headers["LOCATION_NAME"][0]) ? filter_var($headers["LOCATION_NAME"][0], FILTER_VALIDATE_BOOLEAN) : null;' . "\n", [
'PROPERTY_NAME' => $propertyName,
'LOCATION_NAME' => $locationName,
]);
$input = 'filter_var($headers["LOCATION_NAME"][0], FILTER_VALIDATE_BOOLEAN)';

break;
case 'string':
$body .= strtr('$this->PROPERTY_NAME = $headers["LOCATION_NAME"][0] ?? null;' . "\n", [
'PROPERTY_NAME' => $propertyName,
'LOCATION_NAME' => $locationName,
]);
$input = '$headers["LOCATION_NAME"][0]';

break;
default:
throw new \RuntimeException(sprintf('Type %s is not yet implemented', $memberShape->getType()));
}

if (!$member->isRequired()) {
$input = 'isset($headers["LOCATION_NAME"][0]) ? ' . $input . ' : null';
}

$body .= strtr('$this->PROPERTY_NAME = ' . $input . ";\n", [
'PROPERTY_NAME' => $propertyName,
'LOCATION_NAME' => $locationName,
]);
}

// This will catch arbitrary values that exists in undefined "headers"
Expand Down
2 changes: 1 addition & 1 deletion src/Service/Route53/src/Result/CreateHostedZoneResponse.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ protected function populateResult(Response $response): void
{
$headers = $response->getHeaders();

$this->location = $headers['location'][0] ?? null;
$this->location = $headers['location'][0];

$data = new \SimpleXMLElement($response->getContent());
$this->hostedZone = new HostedZone([
Expand Down