-
-
Notifications
You must be signed in to change notification settings - Fork 144
Add SQS AddPermission operation #1773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
You need to write the tests. |
Test added. I seem to be failing the change log test. I added an entry, but perhaps not the right format? Any advice? |
You can ignore the The |
The last failing test is about bumping the minor version. Because this PR adds a new feature, the next version of the package will change. |
Yay finally passed the tests. May I suggest adding the additional things that need to be done to the contributing documentation so aid future contributors? I look forward to this PR being accepted. |
thank you @stevenbrookes Please yes, fill free to improve the documentation 🙏 |
New SQS AddPermission operation, required to allow 3rd parties the permission to send messages to queues created using the createQueue endpoint.
I didn't seem to need to do anything after using the generate script - very cool. Let me know if I've missed anything.
As it looks like you are using a monorepo how would I go about using my fork of that in my code while the PR is reviewed and hopefully accepted.
Thanks
Steve