Skip to content

Upgrade php-cs-fixer to version 3.64 #1791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2024
Merged

Upgrade php-cs-fixer to version 3.64 #1791

merged 1 commit into from
Nov 11, 2024

Conversation

jderusse
Copy link
Member

@jderusse jderusse commented Nov 9, 2024

No description provided.

@jderusse jderusse force-pushed the bump-phpcsfixer branch 2 times, most recently from 905e39e to 32dab8b Compare November 9, 2024 15:35
GrahamCampbell
GrahamCampbell suggested changes Nov 9, 2024
View reviewed changes
Copy link
Contributor

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not be adding trailing commas in function definitions, unless we want to raise the minimum PHP version.

@jderusse jderusse merged commit 136fcfd into async-aws:master Nov 11, 2024
16 checks passed
@jderusse jderusse deleted the bump-phpcsfixer branch November 11, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@GrahamCampbell GrahamCampbell GrahamCampbell requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jderusse @GrahamCampbell