Create BedrockRuntime client with InvokeModel operation #1849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
February 28, 2025 15:17
|
I just finished writing tests and fixed what needed to be fixed, however I have a failing test on a generated code (src/Service/BedrockRuntime/src/Result/InvokeModelResponse.php), because the generated code assigns a null value on a property that should not be null. Because I am not allowed to modify generated code, I don't know what to do to fix this test. Any help would be appreciated. Thanks! |
victor-upmeet
changed the title
jderusse
reviewed
Feb 28, 2025
src/Service/BedrockRuntime/tests/Integration/BedrockRuntimeClientTest.php
Outdated
Show resolved
Hide resolved
jderusse
reviewed
Mar 1, 2025
|
@jderusse Do you need me to do anything else on the PR for it to be merged? |
|
thank you @victor-upmeet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a Bedrock Runtime client with InvokeModel operation. Work is still in progress as tests are not implemented yet. This PR is just to check that I'm going in the right direction, and that the base codes for client, operation and other configurations are correct.