Use named cases for the data provider for changelog tests #1880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to identify which package has an invalid changelog as PHPUnit displays the name of the failing case in its output (which is easier to understand than figuring out which component has the index 23 in the data provider).
stof
commented
Apr 17, 2025
| ->in(\dirname(__DIR__, 2) . '/src') | ||
| ->name('CHANGELOG.md'); | ||
|
|
||
| /** @var \SplFileInfo $file */ |
There was a problem hiding this comment.
Finder defines its iterable type as the Symfony\Component\Finder\SplFileInfo, which is the class defining getRelativePath (as it is relative to the folder in which the finder is searching).
This @var was probably added at a time when Symfony did not have the phpdoc annotation providing the info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to identify which package has an invalid changelog as PHPUnit displays the name of the failing case in its output (which is easier to understand than figuring out which component has the index 23 in the data provider).
See https://github.com/async-aws/aws/actions/runs/14520270313/job/40739268792?pr=1879#step:8:137 for the output with the old test