do not call setAccessible() on PHP 8.1+ #1931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
force-pushed
the
php-8.5
branch
2 times, most recently
from
77b136a to
c4ae92c
Compare
This operation has no effect since PHP 8.1 and the method is deprecated in PHP 8.5.
xabbuh
commented
Aug 10, 2025
| composer config minimum-stability dev | ||
| composer config prefer-stable true | ||
| composer require --dev --no-update symfony/phpunit-bridge | ||
| composer require --dev --no-update symfony/phpunit-bridge:^7.3.2 |
There was a problem hiding this comment.
we need symfony/symfony#61304
|
The remaining failures will resolve themselves when merging (they are due to |
jderusse
reviewed
Aug 11, 2025
| localExit=0 | ||
| composer require symfony/phpunit-bridge --no-update --no-install | ||
| composer require symfony/phpunit-bridge:^7.3.2@dev --dev --no-update --no-install |
There was a problem hiding this comment.
only once 7.3.2 has been tagged, the minimum stability setting to dev further above is not applied to all composer.json files (see https://github.com/xabbuh/aws/actions/runs/16861959545/job/47763456579#step:8:32)
|
thank you @xabbuh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This operation has no effect since PHP 8.1 and the method is deprecated in PHP 8.5.