add decoder implementation #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielb1
force-pushed
the
add-decoder
branch
10 times, most recently
from
46de0e4 to
40f97a5
Compare
rcoh
reviewed
Apr 17, 2025
Collaborator
rcoh
left a comment
rcoh
left a comment
There was a problem hiding this comment.
can you give at least one example of how to use the decoder?
Contributor
Author
|
added example |
rcoh
approved these changes
Apr 17, 2025
Collaborator
rcoh
left a comment
rcoh
left a comment
There was a problem hiding this comment.
LGTM. A follow up with a test (even one that just uses a hard coded JFR and asserts on output) would make this much easier to modify in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📬 Issue #, if available:
✍️ Description of changes:
🔏 By submitting this pull request