fix: recursion detection to allow same resolved $ref in different branches#1241
Open
catosaurusrex2003 wants to merge 4 commits intoasyncapi:masterfrom
Open
fix: recursion detection to allow same resolved $ref in different branches#1241catosaurusrex2003 wants to merge 4 commits intoasyncapi:masterfrom
catosaurusrex2003 wants to merge 4 commits intoasyncapi:masterfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The Problem
The recursion detection algorithm incorrectly throws "too much recursion" errors when the same external
$refappears in multiple branches (e.g. in the schema provided in #1236c1andc2both referencing the same external component).This happens because the algorithm used a global
WeakSetthat flagged any object seen before, even if it was in a different branch.Solution
Replaced global
WeakSettracking with path-based tracking usingSet<object>. Each branch now gets its own copy of the path, allowing the same object to appear in different branches while still detecting true circular references.Key Changes
WeakSet→Set<object>to enable path copyingvisited→visitedInPathfor clarityRelated issue(s)
#1236