-
-
Notifications
You must be signed in to change notification settings - Fork 288
feat: enable --compile flag #1953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Siddhi sahu <[email protected]>
|
|
Hi @Siddhi-sahu, I reviewed the PR and tested it locally. Looks good
Pending
Overall, the implementation looks solid. Let me know if you need any help with the tests or changeset. |
|
/u |
|
|
Please add options accordingly here https://github.com/asyncapi/cli/blob/master/src/apps/cli/internal/base/BaseGeneratorCommand.ts#L47 I don't the compile option right now does anything meaningful till it's passed to generator. |



Description
hopefully fixes #1829
I am new here, and still trying to understand the codebase.
I have opened the pr but I am not entirely sure if I am going into the right direction. Any little push would be appreciated.
Thank you for your time.
@Shurtu-gal
Related issue(s)