You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR addresses several SonarCloud code quality issues in github-action/entrypoint.sh to improve code maintainability and follow bash best practices.
Changes
Added explicit return 0 statements to all functions (handle_file_error, handle_validate, handle_optimize, handle_generate, handle_convert) for clarity and consistency
Assigned positional parameter $1 to a local variable filepath in handle_file_error function for better readability
Redirected error messages to stderr (>&2) in handle_file_error function to properly separate error output from standard output
Benefits
Improved code clarity with explicit return statements
Better error handling by redirecting errors to stderr
Enhanced maintainability by using descriptive local variables instead of positional parameters
All changes comply with SonarCloud code quality standards
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
@Shurtu-gal sir, @AayushSaini101 sir
Could you please review this small/trivial contribution?
I’ve implemented a few SonarCloud-suggested improvements to address multiple MEDIUM severity issues in entrypoint.sh, mainly related to bash best practices and code quality.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DarshanCode2005
requested review from
AayushSaini101,
Amzani,
Shurtu-gal,
Souvikns and
asyncapi-bot-eve
as code owners
fixes: #1881
Description
This PR addresses several SonarCloud code quality issues in
github-action/entrypoint.shto improve code maintainability and follow bash best practices.Changes
return 0statements to all functions (handle_file_error,handle_validate,handle_optimize,handle_generate,handle_convert) for clarity and consistency$1to a local variablefilepathinhandle_file_errorfunction for better readability>&2) inhandle_file_errorfunction to properly separate error output from standard outputBenefits