Skip to content

Conversation

@DarshanCode2005
Copy link
Contributor

@DarshanCode2005 DarshanCode2005 commented Jan 14, 2026

Addresses: #1881

Summary

This PR refactors the autocomplete setup script to resolve SonarCloud-reported code quality issues and modernize Node.js built-in module imports.

Changes

  • Replaced allowedShells array with a Set and updated checks to use Set.prototype.has() as recommended by SonarCloud.

  • Converted Node.js built-in imports to use the node: prefix:

    • child_processnode:child_process
    • osnode:os
    • fsnode:fs
    • pathnode:path
  • No functional or behavioral changes were introduced.

@changeset-bot
Copy link

changeset-bot bot commented Jan 14, 2026

⚠️ No Changeset found

Latest commit: e98cdc9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sonarqubecloud
Copy link

@DarshanCode2005
Copy link
Contributor Author

@AayushSaini101 Sir and @Shurtu-gal Sir, please review this small contribution from my end, and let me know if it's alright. I have fixed all the sonarcloud warnings in enableAutoComplete.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To Triage

Development

Successfully merging this pull request may close these issues.

1 participant