fix: prevent background scroll when popup is open#854
fix: prevent background scroll when popup is open#854Sachinxmpl wants to merge 4 commits intoasyncapi:masterfrom
Conversation
✅ Deploy Preview for peaceful-ramanujan-288045 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
princerajpoot20
left a comment
There was a problem hiding this comment.
LGTM! Good work.
Thanks for the contribution
|
@Sachinxmpl i think this changes is making the test fail, kindly look into it :) |
|
@AceTheCreator My current implementation uses position: fixed on body. |
Yea, i agree we close the popup during test |
|
@AceTheCreator Can i create a issue regarding closing popup during tests. And work on it? |
|
@Sachinxmpl You should do this work as part of this PR only. The reason is that it is not a separate task—it is just updating the test cases to align with your current changes. Hence, it must go in the same PR Another reason is how we can merge this PR if the pipeline is failing due to test failures introduced by your changes. |
d8be84d to
d9ab916
Compare
|
@thulieblack, do we still need the pop-up in any instance moving forward, except for promoting Developer Week? |
|
gentle ping @thulieblack |
|
No we no longer need it as for now, we can hide it for future instances |
Description
overflow: hidden;
position: fixed;
width: 100%;
}
Related issue(s)
Fixes #852