fix: add active state styling to navbar links#922
Open
sh1vam31 wants to merge 3 commits intoasyncapi:masterfrom
Open
fix: add active state styling to navbar links#922sh1vam31 wants to merge 3 commits intoasyncapi:masterfrom
sh1vam31 wants to merge 3 commits intoasyncapi:masterfrom
Conversation
✅ Deploy Preview for peaceful-ramanujan-288045 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds active state styling to navbar links to improve navigation clarity and user experience.
Problem
The navbar previously did not visually indicate which page or section the user is currently viewing. All navigation links appeared identical in both active and inactive states, making navigation unclear—especially for first-time users.
Fixes #896
Changes
Desktop Navbar (navbar.tsx)
useRouterhook from Next.js to detect current route/#about,/#speakers)/editions,/venue/California)Mobile Navbar (navDrop.tsx)
useRouterborder-l-4 border-white) for visual indicator on mobileVisual Changes
Before: All links look the same, no indication of current page
After: Active links display bold text with underline, providing clear visual feedback
Related Issues
Closes #896