Skip to content

fix: prevent infinite recursion for circular tuple array schemas #2438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Varadraj75 wants to merge 2 commits into
base: master
Choose a base branch
from
+54 −20
Open

fix: prevent infinite recursion for circular tuple array schemas #2438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd1494e
fix: prevent infinite recursion for circular tuple array schemas
Varadraj75 Feb 10, 2026
4a6f293
Merge branch 'master' into fix/circular-tuple-array-recursion
Varadraj75 Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/runtime-go-testing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,5 @@ jobs:
-name: Generate Go Models
run: npm run generate:runtime:go
-name: Run runtime Tests
run: npm run test:runtime:go
run: npm run test:runtime:go

71 changes: 52 additions & 19 deletions src/processors/AsyncAPIInputProcessor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,12 +195,12 @@ export class AsyncAPIInputProcessor extends AbstractInputProcessor {
// eslint-disable-next-line sonarjs/cognitive-complexity
static convertToInternalSchema(
schema: AsyncAPISchemaInterface | boolean,
alreadyIteratedSchemas: Map<string, AsyncapiV2Schema> = new Map()
alreadyIteratedSchemas: Map<string, AsyncapiV2Schema> = new Map(),
visitedSchemas: WeakSet<object> = new WeakSet()
): AsyncapiV2Schema | boolean {
if (typeof schema === 'boolean') {
return schema;
}

let schemaUid = schema.id();
//Because the constraint functionality of generators cannot handle -, <, >, we remove them from the id if it's an anonymous schema.
if (
Expand All @@ -225,27 +225,40 @@ export class AsyncAPIInputProcessor extends AbstractInputProcessor {
convertedSchema.allOf = schema
.allOf()!
.map((item: any) =>
this.convertToInternalSchema(item, alreadyIteratedSchemas)
this.convertToInternalSchema(
item,
alreadyIteratedSchemas,
visitedSchemas
)
);
}
if (schema.oneOf()) {
convertedSchema.oneOf = schema
.oneOf()!
.map((item: any) =>
this.convertToInternalSchema(item, alreadyIteratedSchemas)
this.convertToInternalSchema(
item,
alreadyIteratedSchemas,
visitedSchemas
)
);
}
if (schema.anyOf()) {
convertedSchema.anyOf = schema
.anyOf()!
.map((item: any) =>
this.convertToInternalSchema(item, alreadyIteratedSchemas)
this.convertToInternalSchema(
item,
alreadyIteratedSchemas,
visitedSchemas
)
);
}
if (schema.not()) {
convertedSchema.not = this.convertToInternalSchema(
schema.not()!,
alreadyIteratedSchemas
alreadyIteratedSchemas,
visitedSchemas
);
}
if (
Expand All @@ -254,37 +267,43 @@ export class AsyncAPIInputProcessor extends AbstractInputProcessor {
) {
convertedSchema.additionalItems = this.convertToInternalSchema(
schema.additionalItems(),
alreadyIteratedSchemas
alreadyIteratedSchemas,
visitedSchemas
);
}
if (schema.contains()) {
convertedSchema.contains = this.convertToInternalSchema(
schema.contains()!,
alreadyIteratedSchemas
alreadyIteratedSchemas,
visitedSchemas
);
}
if (schema.propertyNames()) {
convertedSchema.propertyNames = this.convertToInternalSchema(
schema.propertyNames()!,
alreadyIteratedSchemas
alreadyIteratedSchemas,
visitedSchemas
);
}
if (schema.if()) {
convertedSchema.if = this.convertToInternalSchema(
schema.if()!,
alreadyIteratedSchemas
alreadyIteratedSchemas,
visitedSchemas
);
}
if (schema.then()) {
convertedSchema.then = this.convertToInternalSchema(
schema.then()!,
alreadyIteratedSchemas
alreadyIteratedSchemas,
visitedSchemas
);
}
if (schema.else()) {
convertedSchema.else = this.convertToInternalSchema(
schema.else()!,
alreadyIteratedSchemas
alreadyIteratedSchemas,
visitedSchemas
);
}
if (
Expand All @@ -293,21 +312,28 @@ export class AsyncAPIInputProcessor extends AbstractInputProcessor {
) {
convertedSchema.additionalProperties = this.convertToInternalSchema(
schema.additionalProperties(),
alreadyIteratedSchemas
alreadyIteratedSchemas,
visitedSchemas
);
}
if (schema.items()) {
if (Array.isArray(schema.items())) {
convertedSchema.items = (
schema.items() as AsyncAPISchemaInterface[]
).map(
(item) => this.convertToInternalSchema(item),
(item) =>
this.convertToInternalSchema(
item,
alreadyIteratedSchemas,
visitedSchemas
),
alreadyIteratedSchemas
);
} else {
convertedSchema.items = this.convertToInternalSchema(
schema.items() as AsyncAPISchemaInterface,
alreadyIteratedSchemas
alreadyIteratedSchemas,
visitedSchemas
);
}
}
Expand All @@ -320,7 +346,8 @@ export class AsyncAPIInputProcessor extends AbstractInputProcessor {
)) {
properties[String(propertyName)] = this.convertToInternalSchema(
propertySchema,
alreadyIteratedSchemas
alreadyIteratedSchemas,
visitedSchemas
);
}
convertedSchema.properties = properties;
Expand All @@ -337,7 +364,8 @@ export class AsyncAPIInputProcessor extends AbstractInputProcessor {
if (typeof dependency === 'object' && !Array.isArray(dependency)) {
dependencies[String(dependencyName)] = this.convertToInternalSchema(
dependency,
alreadyIteratedSchemas
alreadyIteratedSchemas,
visitedSchemas
);
} else {
dependencies[String(dependencyName)] = dependency;
Expand All @@ -357,7 +385,11 @@ export class AsyncAPIInputProcessor extends AbstractInputProcessor {
schemaPatternProperties
)) {
patternProperties[String(patternPropertyName)] =
this.convertToInternalSchema(patternProperty, alreadyIteratedSchemas);
this.convertToInternalSchema(
patternProperty,
alreadyIteratedSchemas,
visitedSchemas
);
}
convertedSchema.patternProperties = patternProperties;
}
Expand All @@ -370,7 +402,8 @@ export class AsyncAPIInputProcessor extends AbstractInputProcessor {
)) {
definitions[String(definitionName)] = this.convertToInternalSchema(
definition,
alreadyIteratedSchemas
alreadyIteratedSchemas,
visitedSchemas
);
}
convertedSchema.definitions = definitions;
Expand Down