#200 implement dotnet best practises#201
Open
thompson-tomo wants to merge 5 commits intoasyncapi:mainfrom
Open
#200 implement dotnet best practises#201thompson-tomo wants to merge 5 commits intoasyncapi:mainfrom
thompson-tomo wants to merge 5 commits intoasyncapi:mainfrom
Conversation
a8e61ef to
01c2907
Compare
01c2907 to
90aba96
Compare
Collaborator
|
I will definitely accept this request when we resolve the issues with the code style and architecture) |
Collaborator
|
Hi, i ready to merge this. @thompson-tomo will you resolve conflict? |
Author
|
Sure will do so in the next couple of days |
9da5647 to
4df2567
Compare
4df2567 to
99aed45
Compare
Author
|
@yurvon-screamo sorry for the delay, find merges resolved. Note i am guessing the large diff is due to the editor config now being run on the csproj files etc |
Collaborator
|
in - name: Run NPM install
shell: sh
run: npm ci
working-directory: ./src/Saunter.UIto: - name: Create package-lock
shell: sh
run: npm install --package-lock-only
working-directory: ./src/Saunter.UI
- name: Run NPM install
shell: sh
run: npm ci
working-directory: ./src/Saunter.UI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reason for the change
Lays the foundation for future changes in particular package splitting.
Related issue(s)
Closes #200