-
-
Notifications
You must be signed in to change notification settings - Fork 130
chore(design-system): change ESLint invocation and ignore node_modules
#1242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✅ Deploy Preview for asyncapi-studio-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for modest-rosalind-098b67 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/rtm |
node_modules
|
|
@princerajpoot20 you would need to review this. |
princerajpoot20
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @batchu5 Thanks for your contribution
|
/rtm |



This PR:
Modifies the Design System's
lintcommand toeslint . --ext .ts --ext .tsx --ext .js --ext .jsxto prevent parsing errors on Windows PowerShell (which treats commas as array separators, passing incorrect arguments to ESLint) and to ensure cross-shell compatibility.Explicitly adds the directory
node_modulesto the Design System's.eslintignorebecause the default ignore pattern is not honored.