Skip to content

Conversation

@batchu5
Copy link
Contributor

@batchu5 batchu5 commented Dec 22, 2025

This PR:

  • Modifies the Design System's lint command to eslint . --ext .ts --ext .tsx --ext .js --ext .jsx to prevent parsing errors on Windows PowerShell (which treats commas as array separators, passing incorrect arguments to ESLint) and to ensure cross-shell compatibility.

  • Explicitly adds the directory node_modules to the Design System's .eslintignore because the default ignore pattern is not honored.

@changeset-bot
Copy link

changeset-bot bot commented Dec 22, 2025

⚠️ No Changeset found

Latest commit: 5d67bd3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Dec 22, 2025

Deploy Preview for asyncapi-studio-design-system ready!

Name Link
🔨 Latest commit 5d67bd3
🔍 Latest deploy log https://app.netlify.com/projects/asyncapi-studio-design-system/deploys/69652d04a27ecc00078c2213
😎 Deploy Preview https://deploy-preview-1242--asyncapi-studio-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 22, 2025

Deploy Preview for modest-rosalind-098b67 ready!

Name Link
🔨 Latest commit 5d67bd3
🔍 Latest deploy log https://app.netlify.com/projects/modest-rosalind-098b67/deploys/69652d0407be220008a3d7a3
😎 Deploy Preview https://deploy-preview-1242--modest-rosalind-098b67.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Shurtu-gal Shurtu-gal changed the title add node_modules to .eslintignore to prevent errors on windows chore: add node_modules to .eslintignore to prevent errors on windows Dec 22, 2025
@Shurtu-gal
Copy link
Collaborator

/rtm

@batchu5 batchu5 changed the title chore: add node_modules to .eslintignore to prevent errors on windows chore(design-system): change ESLint invocation and ignore node_modules Dec 22, 2025
@sonarqubecloud
Copy link

@Shurtu-gal
Copy link
Collaborator

@princerajpoot20 you would need to review this.

Copy link
Member

@princerajpoot20 princerajpoot20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @batchu5 Thanks for your contribution

@github-project-automation github-project-automation bot moved this from Backlog to Ready in Studio - Kanban Jan 12, 2026
@princerajpoot20
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 7c526fc into asyncapi:master Jan 12, 2026
20 checks passed
@github-project-automation github-project-automation bot moved this from Ready to Done in Studio - Kanban Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants