Skip to content

Remove hardcoded tool project version#11

Merged
rogeralsing merged 1 commit intomainfrom
remove-tool-project-version
Jan 18, 2026
Merged

Remove hardcoded tool project version#11
rogeralsing merged 1 commit intomainfrom
remove-tool-project-version

Conversation

@rogeralsing
Copy link
Contributor

Summary

  • remove the hardcoded package version from the tool project
  • add a test to ensure the tool project does not define a Version element

Testing

  • dotnet test Asynkron.Profiler.sln

Fixes #2

@rogeralsing
Copy link
Contributor Author

Progress: removed hardcoded from ProfileTool project and added a guard test. Tests run: Determining projects to restore...
All projects are up-to-date for restore.
Asynkron.Profiler.Core -> /Users/rogerjohansson/git/asynkron/Asynkron.Profiler/.worktrees/Remove-hardcoded-Version-from-tool-project-https-github-com-Asynkron-asynkron-profiler-blob-main-src-ProfileTool-ProfileTool-csproj/src/ProfilerCore/bin/Debug/net10.0/Asynkron.Profiler.Core.dll
ProfileTool -> /Users/rogerjohansson/git/asynkron/Asynkron.Profiler/.worktrees/Remove-hardcoded-Version-from-tool-project-https-github-com-Asynkron-asynkron-profiler-blob-main-src-ProfileTool-ProfileTool-csproj/src/ProfileTool/bin/Debug/net10.0/ProfileTool.dll
Asynkron.Profiler.Tests -> /Users/rogerjohansson/git/asynkron/Asynkron.Profiler/.worktrees/Remove-hardcoded-Version-from-tool-project-https-github-com-Asynkron-asynkron-profiler-blob-main-src-ProfileTool-ProfileTool-csproj/tests/Asynkron.Profiler.Tests/bin/Debug/net10.0/Asynkron.Profiler.Tests.dll
Test run for /Users/rogerjohansson/git/asynkron/Asynkron.Profiler/.worktrees/Remove-hardcoded-Version-from-tool-project-https-github-com-Asynkron-asynkron-profiler-blob-main-src-ProfileTool-ProfileTool-csproj/tests/Asynkron.Profiler.Tests/bin/Debug/net10.0/Asynkron.Profiler.Tests.dll (.NETCoreApp,Version=v10.0)
VSTest version 18.0.1 (arm64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.

Passed! - Failed: 0, Passed: 21, Skipped: 0, Total: 21, Duration: 53 ms - Asynkron.Profiler.Tests.dll (net10.0).

@rogeralsing rogeralsing merged commit a57c2b8 into main Jan 18, 2026
1 check passed
@rogeralsing rogeralsing mentioned this pull request Jan 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TODO

1 participant