Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Proto.Actor/Context/ActorContext.cs
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ public void Forward(PID target)

public void Request(PID target, object message, PID? sender)
{
var messageEnvelope = MessageEnvelope.WithSender(message, sender!);
var messageEnvelope = MessageEnvelope.WithSender(message, sender);
SendUserMessage(target, messageEnvelope);
}

Expand Down
4 changes: 2 additions & 2 deletions src/Proto.Actor/EventStream/EventProbeLogMessages.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ internal static partial class EventProbeLogMessages
internal static partial void SettingExpectation(this ILogger logger);

[LoggerMessage(1, LogLevel.Debug, "Got expected event {Event}")]
internal static partial void GotExpectedEvent(this ILogger logger, object @event);
internal static partial void GotExpectedEvent(this ILogger logger, object? @event);

[LoggerMessage(2, LogLevel.Debug, "Got unexpected {Event}, ignoring")]
internal static partial void GotUnexpectedEvent(this ILogger logger, object @event);
internal static partial void GotUnexpectedEvent(this ILogger logger, object? @event);
}
8 changes: 4 additions & 4 deletions src/Proto.Actor/Messages/MessageEnvelope.cs
Original file line number Diff line number Diff line change
Expand Up @@ -67,17 +67,17 @@ public static MessageEnvelope Wrap(object message, MessageHeader header) => mess
/// <summary>
/// Adds a sender <see cref="PID" /> to the message envelope.
/// </summary>
/// <param name="sender"></param>
/// <param name="sender">Sender <see cref="PID" /> or <c>null</c></param>
/// <returns>New envelope</returns>
public MessageEnvelope WithSender(PID sender) => this with { Sender = sender };
public MessageEnvelope WithSender(PID? sender) => this with { Sender = sender };

/// <summary>
/// Adds a sender <see cref="PID" /> if the message is an envelope, otherwise creates a new envelope with the given sender.
/// </summary>
/// <param name="message"></param>
/// <param name="sender"></param>
/// <param name="sender">Sender <see cref="PID" /> or <c>null</c></param>
/// <returns>New envelope</returns>
public static MessageEnvelope WithSender(object message, PID sender) => message is MessageEnvelope env
public static MessageEnvelope WithSender(object message, PID? sender) => message is MessageEnvelope env
? env.WithSender(sender)
: new MessageEnvelope(message, sender);

Expand Down
4 changes: 2 additions & 2 deletions src/Proto.Actor/Supervision/AllForOneStrategyLogMessages.cs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ namespace Proto;

internal static partial class AllForOneStrategyLogMessages
{
// `reason` is kept so the logger captures the exception automatically
// "exception" parameter ensures the exception is logged automatically
[LoggerMessage(0, LogLevel.Information, "{Action} {Actor}")]
internal static partial void AllForOneStrategyAction(this ILogger logger, string action, PID actor, Exception reason);
internal static partial void AllForOneStrategyAction(this ILogger logger, string action, PID actor, Exception exception);
}
4 changes: 2 additions & 2 deletions src/Proto.Actor/Supervision/OneForOneStrategyLogMessages.cs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ namespace Proto;

internal static partial class OneForOneStrategyLogMessages
{
// `reason` is kept so the logger captures the exception automatically
// "exception" parameter ensures the exception is logged automatically
[LoggerMessage(0, LogLevel.Information, "{Action} {Actor}")]
internal static partial void OneForOneStrategyAction(this ILogger logger, string action, PID actor, Exception reason);
internal static partial void OneForOneStrategyAction(this ILogger logger, string action, PID actor, Exception exception);
}
Loading