fix(python): Use pathlib for os-independent unit tests #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asyrjasalo
requested changes
Oct 22, 2025
Owner
asyrjasalo
left a comment
asyrjasalo
left a comment
There was a problem hiding this comment.
There is still a few path.join left. Re-check keywords.py.
Owner
|
Also, you can likely replace path.isfile with pathlib as well. Consistency. In the end you should be able to remove |
kivipe
force-pushed
the
output_pathlib
branch
from
87448a4 to
5b5cc15
Compare
Contributor
Author
|
Thank you for your feedback. After checking and refactoring I was able to remove path and getcwd imports. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another try for #144. As requested, I converted all path operations I found into pathlib methods