Conversation
|
Have you tried using an |
I did not, as that is not really part of the iterm2 protocol spec, so who would really know about that? (i had also tried searching around, but didnt find anything related, aside from the already mentioned gitlab issue)
Though it would still be a good idea, in my opinion, to add But thanks for pointing this out, it could be a ok indicator until |
|
Updated the implementation to fall-back to checking for |
I can't remember where exactly, but it was suggested in an issue of one of the terminals that supports IIP. The iTerm2 maintainer was pinged in the discussion, and I'm certain he said he would add that to the spec, but I guess that never happened if it's not there now. It doesn't make a lot of difference to me either way, because I don't use iTerm2 images, but I figured it would be a lot easier to get a few more terminals supporting |
eac5eb5 to
43631f4
Compare
based on currently undocumented escape sequence
As a indicator if iterm image protocol is supported.
43631f4 to
48e5464
Compare
This PR implements a way to query iterm2 inline image protocol support.
This has recently been published at iterm2: Terminal Feature Reporting
re #84
re #79
Depends on #86 and #85This is a DRAFT as of now the\x1b]1337;Capabilities\x07query is undocumented and only implemented by iterm2 itself, see the iterm2 discussion.This will stay a DRAFT until at least some other terminal implements this.
Anyone who is on macos and uses iterm2, i would appreciate testing with
viuagainst this PR with the followingviupatch applied and report theIterm2 Responselog:For convenience, use my fork of
viuat branchtestIterm2Query(it sets to only useiterm2protocol and points viuer dependency to this PR branch)