Reimplement mouse mode #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

kakra wants to merge 1 commit into atar-axis:master from kakra:queue/reimplement-mouse-mode

Collaborator

kakra commented Mar 28, 2021 •

edited

Loading

Todo:

Add support for mouse buttons (left, right, forward, backward)
Add support for scrolling
Add support for simple keyboard events (cursor keys, enter, escape)
Add support for haptic feedback on button clicks
Re-structure into separate source-code files just before v0.10 release so we can still back-port fixes until then
Test profile switching with XBE2 controller

kakra added 0 | type: enhancement 1 | state: work in progress labels

kakra added this to the v0.10 milestone

kakra force-pushed the queue/reimplement-mouse-mode branch 3 times, most recently from 1bcec4b to 632d509 Compare

April 1, 2021 20:57

This was referenced Apr 1, 2021

Use Gamepad as Mouse on GUI #99

Open

Virtual Mouse (redone) #160

Closed

kakra force-pushed the queue/reimplement-mouse-mode branch 5 times, most recently from 67dbffd to 6f3058f Compare

April 3, 2021 16:48

kakra force-pushed the queue/reimplement-mouse-mode branch 2 times, most recently from 6951ccd to 9856f89 Compare

April 12, 2021 19:26

kakra force-pushed the queue/reimplement-mouse-mode branch 3 times, most recently from 1f49e7c to 77ecd72 Compare

June 25, 2021 21:28

kakra force-pushed the queue/reimplement-mouse-mode branch 2 times, most recently from 217abf9 to 43919e5 Compare

July 6, 2021 21:22

kakra force-pushed the queue/reimplement-mouse-mode branch from 43919e5 to 0dfa5bd Compare

August 28, 2021 21:37

JonisK mentioned this pull request

Mouse mode doesn't move the cursor #333

Open

26 tasks

kakra force-pushed the queue/reimplement-mouse-mode branch from 0dfa5bd to b7fac5d Compare

March 6, 2022 20:24

kakra force-pushed the queue/reimplement-mouse-mode branch from b7fac5d to 6b89563 Compare

April 30, 2022 11:39

kakra force-pushed the queue/reimplement-mouse-mode branch from 6b89563 to 26a0ecc Compare

May 9, 2022 06:44

kakra force-pushed the queue/reimplement-mouse-mode branch 3 times, most recently from a9a4633 to 0a2226b Compare

May 30, 2022 22:30

kakra force-pushed the queue/reimplement-mouse-mode branch from 0a2226b to 118d57c Compare

September 17, 2022 20:28

kakra mentioned this pull request

Xbox series controllers Guide/Share button held to become mouse #437

Closed

10 tasks

kakra added a commit that referenced this pull request


          xpadneo, core: Handle sync events in xpadneo

5ab9bcf

To properly sync our multiple sub-devices, we need to synchronize the
input frame in xpadneo instead of the generic HID handler, otherwise
we may see input late or duplicated.

See-also: #460
See-also: #282
Signed-off-by: Kai Krakow <[email protected]>

kakra force-pushed the queue/reimplement-mouse-mode branch 2 times, most recently from f16f26f to d4539af Compare

March 4, 2024 00:51

kakra marked this pull request as ready for review

March 4, 2024 00:51

kakra force-pushed the queue/reimplement-mouse-mode branch 2 times, most recently from f9ffcf5 to 55715d0 Compare

March 4, 2024 01:35

kakra added 1 | state: testing solution and removed 1 | state: work in progress labels

kakra force-pushed the queue/reimplement-mouse-mode branch from 55715d0 to 89b24ac Compare

April 22, 2024 22:17

kakra mentioned this pull request

Triggers getting stuck after releasing them #474

Closed

41 tasks

kakra force-pushed the queue/reimplement-mouse-mode branch from 89b24ac to 55466f5 Compare

November 24, 2024 14:22

kakra mentioned this pull request

How do I make the controller use key presses so it works with most things? #511

Open

kakra force-pushed the queue/reimplement-mouse-mode branch from 55466f5 to ffbb921 Compare

December 2, 2024 18:49

kakra force-pushed the queue/reimplement-mouse-mode branch 2 times, most recently from 447f301 to c5620e8 Compare

December 23, 2024 13:02

qlty-cloud-legacy bot commented Dec 23, 2024

Code Climate has analyzed commit c5620e8 and detected 0 issues on this pull request.

View more on Code Climate.

kakra requested a review from Copilot

September 19, 2025 09:38

Copilot AI reviewed

View reviewed changes

Copilot AI left a comment

Pull Request Overview

This PR reimplements the mouse mode functionality for Xbox controllers, adding support for mouse buttons, scrolling, and basic keyboard events. The implementation includes timer-based mouse movement reporting and maps controller inputs to mouse and keyboard actions.

Adds a new mouse.c file with comprehensive mouse emulation functionality
Implements timer-based mouse movement and scrolling with error accumulation
Maps controller inputs to mouse buttons, cursor keys, and special functions

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
hid-xpadneo/src/xpadneo/mouse.c	New file implementing complete mouse emulation with analog stick movement, button mapping, and keyboard event handling
hid-xpadneo/src/xpadneo/keyboard.c	Adds keyboard capabilities for mouse mode (arrow keys, Enter, Escape)
hid-xpadneo/src/xpadneo/core.c	Adds mouse synchronization support and consumer control error handling
hid-xpadneo/src/xpadneo/consumer.c	Enables on-screen keyboard capability for mouse mode
hid-xpadneo/src/xpadneo.h	Adds mouse-related data structures, timer, and function declarations
hid-xpadneo/src/hid-xpadneo.c	Integrates mouse functionality into main driver with timer setup and event routing
hid-xpadneo/src/Makefile	Includes mouse.c in the build
docs/README.md	Documents mouse mode usage and controls

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

hid-xpadneo/src/xpadneo/mouse.c

+              	xdata->profile_switched = true;
+              }
+              #define mouse_report_rel(a,v) if((v)!=0)input_report_rel(mouse,(a),(v))

Copilot AI Sep 19, 2025

The macro lacks spaces around operators and parameters, making it hard to read. Consider reformatting as #define mouse_report_rel(a, v) if ((v) != 0) input_report_rel(mouse, (a), (v))

Suggested change

      
            #define mouse_report_rel(a,v) if((v)!=0)input_report_rel(mouse,(a),(v))
          
            #define mouse_report_rel(a, v) if ((v) != 0) input_report_rel(mouse, (a), (v))

Copilot uses AI. Check for mistakes.

hid-xpadneo/src/xpadneo/mouse.c

+              }
+              #define rescale_axis(v,d) (((v)<(d)&&(v)>-(d))?0:(32768*((v)>0?(v)-(d):(v)+(d))/(32768-(d))))
+              #define digipad(v,v1,v2,v3) (((v==(v1))||(v==(v2))||(v==(v3)))?1:0)

Copilot AI Sep 19, 2025

These macros contain complex logic with magic numbers (3072, 32768) and lack spacing around operators. Consider replacing with properly formatted inline functions with descriptive parameter names and documented constants.

Suggested change

      
            #define digipad(v,v1,v2,v3) (((v==(v1))||(v==(v2))||(v==(v3)))?1:0)
          
            /**
          
             * digipad - Check if value matches any of three possible values.
          
             * @value: The value to check.
          
             * @v1: First possible value.
          
             * @v2: Second possible value.
          
             * @v3: Third possible value.
          
             *
          
             * Returns 1 if value equals v1, v2, or v3; otherwise returns 0.
          
             */
          
            static inline int digipad(int value, int v1, int v2, int v3)
          
            {
          
                return (value == v1) || (value == v2) || (value == v3);
          
            }

Copilot uses AI. Check for mistakes.

hid-xpadneo/src/xpadneo/mouse.c

Comment on lines +118 to +121

+              				input_report_key(keyboard, KEY_UP, digipad(value, 8, 1, 2));
+              				input_report_key(keyboard, KEY_RIGHT, digipad(value, 2, 3, 4));
+              				input_report_key(keyboard, KEY_DOWN, digipad(value, 4, 5, 6));
+              				input_report_key(keyboard, KEY_LEFT, digipad(value, 6, 7, 8));

Copilot AI Sep 19, 2025

The magic numbers (1, 2, 3, 4, 5, 6, 7, 8) representing directional values should be defined as named constants to improve code readability and maintainability.

Copilot uses AI. Check for mistakes.

hid-xpadneo/src/xpadneo/mouse.c

+              			xdata->mouse_state.wheel_y = rescale_axis(value - 32768, 3072);
+              			return 1;
+              		case ABS_RZ:
+              			if (xdata->mouse_state.analog_button.left && value < 384) {

Copilot AI Sep 19, 2025

The threshold values 384 and 640 are magic numbers that should be defined as named constants to clarify their purpose and make them easier to maintain.

Copilot uses AI. Check for mistakes.

hid-xpadneo/src/xpadneo/mouse.c

+              				xdata->mouse_state.analog_button.left = false;
+              				input_report_key(mouse, BTN_LEFT, 0);
+              				xdata->mouse_sync = true;
+              			} else if (!xdata->mouse_state.analog_button.left && value > 640) {

Copilot AI Sep 19, 2025

The threshold values 384 and 640 are magic numbers that should be defined as named constants to clarify their purpose and make them easier to maintain.

Copilot uses AI. Check for mistakes.

hid-xpadneo/src/xpadneo/mouse.c

+              			}
+              			return 1;
+              		case ABS_Z:
+              			if (xdata->mouse_state.analog_button.right && value < 384) {

Copilot AI Sep 19, 2025

The threshold values 384 and 640 are magic numbers that should be defined as named constants to clarify their purpose and make them easier to maintain.

Copilot uses AI. Check for mistakes.

hid-xpadneo/src/xpadneo/mouse.c

+              				xdata->mouse_state.analog_button.right = false;
+              				input_report_key(mouse, BTN_RIGHT, 0);
+              				xdata->mouse_sync = true;
+              			} else if (!xdata->mouse_state.analog_button.right && value > 640) {

Copilot AI Sep 19, 2025

The threshold values 384 and 640 are magic numbers that should be defined as named constants to clarify their purpose and make them easier to maintain.

Copilot uses AI. Check for mistakes.

docs/README.md Outdated Show resolved Hide resolved

kakra force-pushed the queue/reimplement-mouse-mode branch 4 times, most recently from 675bdb3 to ce6c2d2 Compare

December 20, 2025 14:14

kakra force-pushed the queue/reimplement-mouse-mode branch 3 times, most recently from 4a3a520 to bfda3d3 Compare

December 27, 2025 22:18

kakra force-pushed the master branch from 21f7d79 to 81ab562 Compare

December 27, 2025 22:21

kakra force-pushed the queue/reimplement-mouse-mode branch 2 times, most recently from 9b996e3 to 800a0de Compare

December 27, 2025 23:04


          xpadneo, mouse: Implement mouse support

2f68332

Add an optional "mouse profile" that turns supported Xbox controllers
into a couch-friendly mouse/keyboard input device. The mode can be
toggled via Guide+Select and reuses the existing input infrastructure
by registering an additional (synthetic) mouse device.

In mouse mode:
- left stick moves the pointer (REL_X/REL_Y)
- right stick scrolls (REL_WHEEL/REL_HWHEEL)
- triggers act as left/right mouse buttons with hysteresis
- shoulder buttons provide back/forward
- D-pad generates cursor keys (keyboard interface)
- A/B map to Enter/Escape (keyboard interface)
- X triggers the on-screen keyboard key event (consumer control)

Movement and scrolling are emitted periodically via a timer to provide
a stable update rate and to keep input processing isolated from HID
report timing.

Co-authored-by: Jacob Essex <[email protected]>
Co-authored-by: Florian Dollinger <[email protected]>
Closes: atar-axis#99
Closes: atar-axis#105
Closes: atar-axis#160
Closes: atar-axis#511
Fixes: atar-axis#333
See-also: atar-axis#419
See-also: atar-axis#435
Signed-off-by: Kai Krakow <[email protected]>

kakra force-pushed the queue/reimplement-mouse-mode branch from 800a0de to 2f68332 Compare

December 28, 2025 13:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 | type: enhancement 1 | state: testing solution