Skip to content

fix: assign sequential IDs and write records in order during parallel… #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atasoglu merged 1 commit into from
Nov 9, 2025
Merged

fix: assign sequential IDs and write records in order during parallel… #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/toolsgen/core/parallel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ def generate_records_parallel(

results_by_index: Dict[int, Record] = {}
failed = 0
next_id_to_write = 0

ctx = mp.get_context("spawn")
with ProcessPoolExecutor(
Expand All @@ -156,6 +157,13 @@ def generate_records_parallel(
if sample_result.record:
record = Record.model_validate(sample_result.record)
results_by_index[sample_result.sample_index] = record

while next_id_to_write in results_by_index:
rec = results_by_index[next_id_to_write]
rec.id = f"record_{next_id_to_write:06d}"
append_record_jsonl(rec, jsonl_path)
del results_by_index[next_id_to_write]
next_id_to_write += 1
else:
tqdm.write(
"Warning: Failed to generate sample "
Expand All @@ -170,8 +178,4 @@ def generate_records_parallel(
pbar.update(1)

all_records = [results_by_index[i] for i in sorted(results_by_index.keys())]
for idx, record in enumerate(all_records):
record.id = f"record_{idx:06d}"
append_record_jsonl(record, jsonl_path)

return all_records, failed