Skip to content

Improve detection of Forge fatal errors #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JulianVennen merged 5 commits into from
Jan 27, 2025
Merged

Improve detection of Forge fatal errors #102

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
30a3882
Add test log with multiple fatal mod errors
JulianVennen Jan 27, 2025
698168b
Remove whitespace from mod name
JulianVennen Jan 27, 2025
2742af1
Detect multiple fatal mod problems at once
JulianVennen Jan 27, 2025
1f0bc71
Merge branch 'master' into forge-fatal-erros
JulianVennen Jan 27, 2025
6e20544
Regenerate tests
JulianVennen Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Analysis/Problem/Forge/ModFatalProblem.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public static function getPatterns(): array
{
return [
'/\s*U[LCHIJAD]*E\s+(\w+)\{([^\}]+)\} \[([^\]]+)\] \(([^\)]+)\)/',
'/Loading errors encountered: \[\n([^\(]+) \(([^\)]+)\) has failed to load correctly/'
'/^\s*([^\(\n]+) \(([^\)]+)\) has failed to load correctly/m'
];
}

Expand Down Expand Up @@ -93,4 +93,4 @@ public function getModId(): ?string
{
return $this->modId;
}
}
}
Loading
Loading