Make members for matches not-nullable

src/Analysis/Problem/Bukkit/AmbiguousPluginNameProblem.php

@@ -13,8 +13,8 @@
  */
 class AmbiguousPluginNameProblem extends PluginProblem
 {
-    protected ?string $firstPluginPath = null;
-    protected ?string $secondPluginPath = null;
+    protected string $firstPluginPath;
+    protected string $secondPluginPath;
 
     /**
      * Get a human-readable message

src/Analysis/Problem/Bukkit/PluginCommandExceptionProblem.php

@@ -14,7 +14,7 @@
  */
 class PluginCommandExceptionProblem extends PluginProblem
 {
-    protected ?string $command = null;
+    protected string $command;
 
     /**
      * Get a human-readable message

src/Analysis/Problem/Bukkit/PluginDependencyProblem.php

@@ -13,7 +13,7 @@
  */
 class PluginDependencyProblem extends PluginFileProblem
 {
-    protected ?string $dependencyPluginName = null;
+    protected string $dependencyPluginName;
 
     /**
      * @return string|null

src/Analysis/Problem/Bukkit/PluginFileProblem.php

@@ -18,12 +18,12 @@
  */
 abstract class PluginFileProblem extends PluginProblem
 {
-    protected ?string $pluginFilePath = null;
+    protected string $pluginFilePath;
 
     /**
-     * @return string|null
+     * @return string
      */
-    public function getPluginFilePath(): ?string
+    public function getPluginFilePath(): string
     {
         return $this->pluginFilePath;
     }

src/Analysis/Problem/Bukkit/PluginProblem.php

@@ -20,12 +20,12 @@
  */
 abstract class PluginProblem extends BukkitProblem
 {
-    protected ?string $pluginName = null;
+    protected string $pluginName;
 
     /**
-     * @return string|null
+     * @return string
      */
-    public function getPluginName(): ?string
+    public function getPluginName(): string
     {
         return $this->pluginName;
     }

src/Analysis/Problem/Bukkit/UnsupportedApiVersionProblem.php

@@ -7,12 +7,12 @@
 
 class UnsupportedApiVersionProblem extends PluginFileProblem
 {
-    protected ?string $apiVersion = null;
+    protected string $apiVersion;
 
     /**
-     * @return string|null
+     * @return string
      */
-    public function getApiVersion(): ?string
+    public function getApiVersion(): string
     {
         return $this->apiVersion;
     }

src/Analysis/Problem/Bukkit/WorldDuplicateProblem.php

@@ -12,12 +12,12 @@
  */
 class WorldDuplicateProblem extends BukkitProblem
 {
-    protected ?string $worldName = null;
+    protected string $worldName;
 
     /**
-     * @return string|null
+     * @return string
      */
-    public function getWorldName(): ?string
+    public function getWorldName(): string
     {
         return $this->worldName;
     }

src/Analysis/Problem/CrashReport/TickingEntityProblem.php

@@ -32,7 +32,7 @@ public function getMessage(): string
     {
         return Translator::getInstance()->getTranslation("ticking-entity-problem", [
             "name" => $this->getName(),
-            "location" => $this->getLocationX() . ", " . $this->getLocationY() . ", " . $this->getLocationZ()
+            "location" => sprintf("%s, %s, %s", $this->getLocationX(), $this->getLocationY(), $this->getLocationZ())
         ]);
     }
 

src/Analysis/Problem/Fabric/FabricIncompatibleModsProblem.php

@@ -7,7 +7,7 @@
 
 class FabricIncompatibleModsProblem extends FabricModProblem
 {
-    protected ?string $secondModName = null;
+    protected string $secondModName;
 
     public function getMessage(): string
     {
@@ -18,9 +18,9 @@ public function getMessage(): string
     }
 
     /**
-     * @return string|null
+     * @return string
      */
-    public function getSecondModName(): ?string
+    public function getSecondModName(): string
     {
         return $this->secondModName;
     }

src/Analysis/Problem/Fabric/FabricModProblem.php

@@ -16,12 +16,12 @@ abstract class FabricModProblem extends FabricProblem
     protected static string $modNamePattern = "(?:'([^\']+)' \((?:[^\)]+)\)|([\w-]+))";
     protected static string $modIDPattern = "([^ ,]+)";
 
-    protected ?string $modName = null;
+    protected string $modName;
 
     /**
-     * @return string|null
+     * @return string
      */
-    public function getModName(): ?string
+    public function getModName(): string
     {
         return $this->modName;
     }

src/Analysis/Problem/Forge/ModDuplicateProblem.php

@@ -13,8 +13,8 @@
  */
 class ModDuplicateProblem extends ModProblem
 {
-    protected ?string $firstModPath = null;
-    protected ?string $secondModPath = null;
+    protected string $firstModPath;
+    protected string $secondModPath;
 
     /**
      * Get a human-readable message
@@ -78,17 +78,17 @@ public function isEqual(InsightInterface $insight): bool
     }
 
     /**
-     * @return string|null
+     * @return string
      */
-    public function getFirstModPath(): ?string
+    public function getFirstModPath(): string
     {
         return $this->firstModPath;
     }
 
     /**
-     * @return string|null
+     * @return string
      */
-    public function getSecondModPath(): ?string
+    public function getSecondModPath(): string
     {
         return $this->secondModPath;
     }

src/Analysis/Problem/Forge/ModFatalProblem.php

@@ -14,9 +14,10 @@
  */
 class ModFatalProblem extends ModProblem
 {
+    protected string $modId;
+
     protected ?string $modFileName = null;
     protected ?string $modVersion = null;
-    protected ?string $modId = null;
 
     /**
      * Get a human-readable message
@@ -87,9 +88,9 @@ public function getModVersion(): ?string
     }
 
     /**
-     * @return string|null
+     * @return string
      */
-    public function getModId(): ?string
+    public function getModId(): string
     {
         return $this->modId;
     }

src/Analysis/Problem/Forge/ModProblem.php

@@ -11,7 +11,7 @@
  */
 abstract class ModProblem extends ForgeProblem
 {
-    protected ?string $modName = null;
+    protected string $modName;
 
     /**
      * @return string

src/Analysis/Problem/Forge/ModWrongMinecraftVersionProblem.php

@@ -13,7 +13,7 @@
  */
 class ModWrongMinecraftVersionProblem extends ModProblem
 {
-    protected ?string $minecraftVersion = null;
+    protected string $minecraftVersion;
 
     /**
      * @return string

src/Analysis/Problem/Forge/MultipleModulesExportProblem.php

@@ -12,7 +12,7 @@
  */
 class MultipleModulesExportProblem extends ModProblem
 {
-    protected ?string $secondModName = null;
+    protected string $secondModName;
 
     /**
      * @return string

src/Analysis/Problem/Forge/WorldModVersionProblem.php

@@ -13,8 +13,8 @@
  */
 class WorldModVersionProblem extends ModProblem
 {
-    protected ?string $currentVersion = null;
-    protected ?string $expectedVersion = null;
+    protected string $currentVersion;
+    protected string $expectedVersion;
 
     /**
      * Get a human-readable message
@@ -60,17 +60,17 @@ public function setMatches(array $matches, mixed $patternKey): void
     }
 
     /**
-     * @return string|null
+     * @return string
      */
-    public function getCurrentVersion(): ?string
+    public function getCurrentVersion(): string
     {
         return $this->currentVersion;
     }
 
     /**
-     * @return string|null
+     * @return string
      */
-    public function getExpectedVersion(): ?string
+    public function getExpectedVersion(): string
     {
         return $this->expectedVersion;
     }

src/Analysis/Problem/Paper/ApiVersionLowerThanAllowedProblem.php

@@ -13,7 +13,7 @@
  */
 class ApiVersionLowerThanAllowedProblem extends PluginFileProblem
 {
-    protected ?string $pluginApiVersion = null;
+    protected string $pluginApiVersion;
 
     /**
      * Get a human-readable message
@@ -50,9 +50,9 @@ public function setMatches(array $matches, mixed $patternKey): void
     }
 
     /**
-     * @return string|null
+     * @return string
      */
-    public function getPluginApiVersion(): ?string
+    public function getPluginApiVersion(): string
     {
         return $this->pluginApiVersion;
     }

src/Analysis/Problem/Pocketmine/PluginDependencyProblem.php

@@ -13,12 +13,12 @@
  */
 class PluginDependencyProblem extends PluginProblem
 {
-    protected ?string $dependencyPluginName = null;
+    protected string $dependencyPluginName;
 
     /**
-     * @return string|null
+     * @return string
      */
-    public function getDependencyPluginName(): ?string
+    public function getDependencyPluginName(): string
     {
         return $this->dependencyPluginName;
     }

src/Analysis/Problem/Pocketmine/PluginProblem.php

@@ -11,12 +11,12 @@
  */
 abstract class PluginProblem extends PocketmineProblem
 {
-    protected ?string $pluginName = null;
+    protected string $pluginName;
 
     /**
-     * @return string|null
+     * @return string
      */
-    public function getPluginName(): ?string
+    public function getPluginName(): string
     {
         return $this->pluginName;
     }

src/Analysis/Problem/Pocketmine/PluginRuntimeProblem.php

@@ -13,7 +13,7 @@
  */
 class PluginRuntimeProblem extends PluginProblem
 {
-    protected ?string $pluginPath = null;
+    protected string $pluginPath;
 
     /**
      * Get a human-readable message
@@ -50,9 +50,9 @@ public function setMatches(array $matches, $patternKey): void
     }
 
     /**
-     * @return string|null
+     * @return string
      */
-    public function getPluginPath(): ?string
+    public function getPluginPath(): string
     {
         return $this->pluginPath;
     }