Skip to content

Commit 3e9fcaa

Browse files
authored
refactor(gha, makefile): improve piplock renewal process log printout (opendatahub-io#1385)
- Split `make refresh-pipfilelock-files` and branch push steps in piplock-renewal workflow for clarity. - Enhanced `pipenv lock` verbosity control in `Makefile`, added failure handling with detailed error logging.
1 parent cf9833b commit 3e9fcaa

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

.github/workflows/piplock-renewal.yaml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,12 @@ jobs:
6565
run: pip install pipenv
6666

6767
# Run makefile recipe to refresh Pipfile.lock and push changes back to the branch
68-
- name: Run make refresh-pipfilelock-files and push the changes back to the branch
68+
- name: Run `make refresh-pipfilelock-files`
6969
run: |
7070
make refresh-pipfilelock-files PYTHON_VERSION=${{ env.PYTHON_VERSION }} INCLUDE_OPT_DIRS=${{ env.INCLUDE_OPT_DIRS }}
71+
72+
- name: Push the changes back to the branch
73+
run: |
7174
git add .
7275
git commit -m "Update Pipfile.lock files by piplock-renewal.yaml action"
7376
git push origin ${{ env.BRANCH }}

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -455,7 +455,7 @@ refresh-pipfilelock-files:
455455
echo "Updating $(PYTHON_VERSION) Pipfile.lock in $$dir"
456456
cd $$dir
457457
if [ -f "Pipfile" ]; then
458-
pipenv lock --verbose
458+
pipenv lock || pipenv lock --verbose
459459
else
460460
echo "No Pipfile found in $$dir, skipping."
461461
fi

0 commit comments

Comments
 (0)