[Breaking] Remove scope assumption with LiveChat login and fix playground #432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
|
Breaking change is indeed an issue here but I don't think it makes much difference as scope is also defined within LiveChat console (where the app is being registered). If it's left outside it uses the default scope. |
|
I don't understand why you changed it to a string actually, why? |
|
Hey @atinux, it's been a while and I can't recall very well tbh. I had some issues trying to apply default scope and I switched to string to make it as explicit and simple as possible. LiveChat applies default scope set by the app registration screen anyway, so most people won't even set it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes scope assumption with LiveChat login as it caused an issue when default scope would be necessary.
Also, fixes playground issues around LiveChat login.