fix the can VM fit on Host check, added Unit tests for the SimHost#306
Open
vlogic wants to merge 33 commits intoatlarge-research:masterfrom
Open
fix the can VM fit on Host check, added Unit tests for the SimHost#306vlogic wants to merge 33 commits intoatlarge-research:masterfrom
vlogic wants to merge 33 commits intoatlarge-research:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #306 +/- ##
=============================
=============================
☔ View full report in Codecov by Sentry. |
* Added the option to select which files to export. * Updated documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a VM is placed on a host we need to make sure not only the capacity is checked but we also check that the current running VMs plus the new VM can fit.
Implementation Notes ⚒️
External Dependencies 🍀
Breaking API Changes⚠️
Simply specify none (N/A) if not applicable.